Bug 1828993

Summary:	Affinity Modal needs refinement
Product:	OpenShift Container Platform	Reporter:	Matt <mcarleto>
Component:	Console Kubevirt Plugin	Assignee:	Gilad Lekner <glekner>
Status:	CLOSED ERRATA	QA Contact:	Radim Hrazdil <rhrazdil>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	4.4	CC:	aos-bugs, glekner, rhrazdil
Target Milestone:	---
Target Release:	4.5.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-07-13 17:32:29 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Matt 2020-04-28 17:14:31 UTC

Description of problem:
The affinity modal has some ux/ui bugs that should be addressed.
We need to align with what we have in the design here:
https://github.com/openshift/openshift-origin-design/pull/383

Empty state should be updated to align with design

When workload labels fields are missing text should read "missing fields in workload labels"

When changes are made action should be "Save" instead of "Apply" (aligns with OCP)

Move "Add affinity rule" to match designs

Provide Affinity rule description according to design

How reproducible:
Very

Steps to Reproduce:
1. Look at Affinity modal via VM details tab

Comment 5 Radim Hrazdil 2020-05-14 11:25:56 UTC

When compared with https://user-images.githubusercontent.com/287880/81417619-d57e6480-9121-11ea-8cae-a1e960514868.png, 
I'm missing horizontal separator line between Node labels and Node fields. It know this is very nit picky, but when working with the dialog, I find it quite difficult to distinguish which Key Values belong to labels and which to fields.

In my opinion, the font size od the titles Node labels and Node fields is too small, so it doesn't look like two separate groups. Additionally, the Key, Operator, Value strings are IMO too far from their related elements.
But since this aspect follows the design in https://github.com/openshift/openshift-origin-design/pull/383#discussion_r422187098, I'd like to ask @Matt for his opinion.

Comment 7 Radim Hrazdil 2020-05-20 06:03:01 UTC

Verified that the separator bar is added and description is provided for both section.

Comment 8 errata-xmlrpc 2020-07-13 17:32:29 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2409

Comment 9 Red Hat Bugzilla 2023-09-14 05:55:53 UTC

The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days