Bug 1829293

Summary:	SRIOV OVN metadata namespaces not cleaned up after ports are unbounded
Product:	Red Hat OpenStack	Reporter:	Eduardo Olivares <eolivare>
Component:	python-networking-ovn	Assignee:	Jakub Libosvar <jlibosva>
Status:	CLOSED ERRATA	QA Contact:	Eduardo Olivares <eolivare>
Severity:	medium	Docs Contact:
Priority:	high
Version:	16.1 (Train)	CC:	apevec, jlibosva, lhh, majopela, scohen
Target Milestone:	beta	Keywords:	Triaged
Target Release:	16.1 (Train on RHEL 8.2)
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	python-networking-ovn-7.1.1-0.20200507153427.fd1c0c3.el8ost	Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-07-29 07:52:15 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1666684

Description Eduardo Olivares 2020-04-29 11:01:21 UTC

Description of problem:
See 'Steps to Reproduce' below.

According to jlibosva:
The external port is deleted from the port_binding table instead of chassis removed and then deleted so the PortBindingUpdate event is never generated.

The metadata agent reacts on Port Binding Update event only. That means when there is a VM and we delete it, it first calls port update to remove the chassis from the port binding, so the port binding is chassis=[] before the PB gets deleted.
In SRIOV scenario we don't do that and we delete a port that is bound.

We need a special event for the sriov deletion case.


Version-Release number of selected component (if applicable):
RHOS-16.1-RHEL-8-20200424.n.0
python3-networking-ovn-7.1.1-0.20200422213423.1d7e326.el8ost.noarch


How reproducible:
100%

Steps to Reproduce:
1. create an SRIOV port on either a tenant or a prov network + create a VM attached to that port - check ovn metadata namespace has been created on a GW node
2. remove that VM - the ovn metadata namespace is not removed from that GW node
3. even after removing the port, the namespace is not removed

Actual results:
OVN metadata namespaces clean up mechanism not working with SRIOV ports

Expected results:
Namespaces should be removed after port is removed

Additional info:

Comment 5 Eduardo Olivares 2020-07-08 16:43:33 UTC

Verified on:
RHOS-16.1-RHEL-8-20200701.n.0
python3-networking-ovn-7.2.1-0.20200611111150.18fabca.el8ost.noarch

Verification Steps:
1. create an SRIOV port on either a tenant or a prov network + create a VM attached to that port - check ovn metadata namespace has been created on a GW node

(undercluod) # openstack port create --vnic-type direct --network nova --binding-profile trusted=true sriov-port-prov-0 && openstack server create --image tempest_image --flavor rhel_flavor_1ram_1vpu_10disk --port sriov-port-prov-0 vm-sriov-prov-0

(controller-0) # ip netns
ovnmeta-fc5a58e8-0e6a-4f09-a6dd-3968c26d6ee3 (id: 0)


2. remove that VM - the ovn metadata namespace is not removed from that GW node
(undercloud) # openstack server delete vm-sriov-prov-0

(controller-0) # ip netns
ovnmeta-fc5a58e8-0e6a-4f09-a6dd-3968c26d6ee3 (id: 0)


3. after removing the port, the namespace is removed
(undercloud) # openstack port delete sriov-port-prov-0

(controller-0) # ip netns
(empty, no namespace shown)

Comment 7 errata-xmlrpc 2020-07-29 07:52:15 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:3148