Bug 1829390
Summary: | Failed hooks dont fail the migration | ||
---|---|---|---|
Product: | OpenShift Container Platform | Reporter: | Sergio <sregidor> |
Component: | Migration Tooling | Assignee: | Jason Montleon <jmontleo> |
Status: | CLOSED ERRATA | QA Contact: | Xin jiang <xjiang> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | 4.4 | CC: | chezhang, dwhatley, dymurray, jmatthew, pvauter, rpattath, whu, xjiang |
Target Milestone: | --- | ||
Target Release: | 4.4.0 | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
URL: | https://github.com/konveyor/mig-controller/pull/518 | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | No Doc Update | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2020-05-28 11:09:56 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Sergio
2020-04-29 13:46:18 UTC
This is a different failure case than I was seeing when I tested. The PR linked will also check for status.conditions[0].reason in addition to status.failed count now. There was also an overall issue with not calling t.fail when we hit an error. We were logging it but not failing the task. That's fixed here as well. Verified in CAM 1.2 stage After the hook failure, we get this status in the migmigration resource status: conditions: - category: Advisory durable: true lastTransitionTime: "2020-05-08T10:14:49Z" message: 'The migration has failed. See: Errors.' reason: PostRestoreHooksFailed status: "True" type: Failed errors: - Hook job hookfail-postrestore-lt6fg failed. itenerary: Failed observedDigest: 7302c6c7dc0e37e5bad574bcb88caba97dcfef0205f47e503cbf6626b71d1250 phase: Completed Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHEA-2020:2326 |