Bug 1829766

Summary: undefined method `tr' for nil:NilClass when trying to get a new DHCP lease from infoblox
Product: Red Hat Satellite Reporter: Kenny Tordeurs <ktordeur>
Component: Infoblox integrationAssignee: Lukas Zapletal <lzap>
Status: CLOSED ERRATA QA Contact: Radovan Drazny <rdrazny>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 6.6.0CC: b.prins, egolov
Target Milestone: 6.8.0Keywords: Triaged
Target Release: Unused   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: tfm-rubygem-smart_proxy_dhcp_infoblox-0.0.16 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-10-27 13:02:11 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Kenny Tordeurs 2020-04-30 09:46:28 UTC 
Description of problem:

Capsule requests lease from Infoblox via its API performing a query to Infoblox which returns a record that has a null value for MAC address which the code does not expect,                                                                                                                                                                 
thus it fails with:
~~~
undefined method `tr' for nil:NilClass
~~~

Version-Release number of selected component (if applicable):
Satellite 6.6

How reproducible:
100%

Steps to Reproduce:
1. Have a lease in dhcp with no mac
2. auto suggest ip for subnet that has infoblox assigned
3.

Actual results:
undefined method `tr' for nil:NilClass


Expected results:
skip the lease that has no mac set.

Additional info:
The following patch skips the lease with empty mac and suggest an ip address:
https://github.com/theforeman/smart_proxy_dhcp_infoblox/pull/48/commits/01702a1356aae1cb55fa137bcffeadddc9f5dc03
Comment 6 Bryan Kearney 2020-05-01 11:56:11 UTC 
Moving this bug to POST for triage into Satellite 6 since the upstream issue https://projects.theforeman.org/issues/29640 has been resolved.
Comment 7 Radovan Drazny 2020-09-30 13:59:55 UTC 
Tested on Sat 6.8 Snap 17 using the reproducer from the initial report. No error on getting an unused IP from Infoblox encountered, even with abandoned leases.
Comment 10 errata-xmlrpc 2020-10-27 13:02:11 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: Satellite 6.8 release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:4366