Bug 1829938

Summary: [IPI baremetal]: machine api tries to fallback incorrectly to config map for dhcp_range
Product: OpenShift Container Platform Reporter: Stephen Benjamin <stbenjam>
Component: Cloud ComputeAssignee: sdasu
Cloud Compute sub component: BareMetal Provider QA Contact: Victor Voronkov <vvoronko>
Status: CLOSED ERRATA Docs Contact:
Severity: urgent    
Priority: urgent CC: agarcial, augol, sdasu, stbenjam, vvoronko
Version: 4.4Flags: stbenjam: needinfo? (agarcial)
Target Milestone: ---   
Target Release: 4.4.z   
Hardware: Unspecified   
OS: Unspecified   
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1826983 Environment:
Last Closed: 2020-06-17 22:26:05 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On: 1826983    
Bug Blocks: 1826922    

Description Stephen Benjamin 2020-04-30 15:41:28 UTC
+++ This bug was initially created as a clone of Bug #1826983 +++

Description of problem:

provisioningDHCPRange can be an empty string in the Provisioning CR if provisioningDHCPExternal is true, but MAO is still trying to fall back to the config map. It should not do that.

IMHO, it is 100% OK to assume the installer creates the Provisioning CR, there's no need for backwards compatibility here, and ideally we'd just remove all of this config map stuff, but if we don't want to do that in 4.5, this case needs to get handled.

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1. Set provisioningDHCPExternal: true, and provisioningDHCPRange to ""

Actual results:

    name: metal3-dnsmasq
    ready: false
    restartCount: 0
    started: false
        message: couldn't find key dhcp_range in ConfigMap
        reason: CreateContainerConfigError

Expected results:

No error.

--- Additional comment from  on 2020-04-23 15:31:39 UTC ---

I would like to see the provisioning CR generated by the installer. That can be gathered by "oc get provisioning -o yaml".

--- Additional comment from Stephen Benjamin on 2020-04-23 15:53:39 UTC ---

After https://github.com/openshift/installer/pull/3496 lands, the template will look like this:

apiVersion: metal3.io/v1alpha1
kind: Provisioning
  name: provisioning-configuration
  provisioningInterface: "enp4s0"
  provisioningIP: ""
  provisioningNetworkCIDR: ""
  provisioningDHCPExternal: true
  provisioningDHCPRange: ""
  provisioningOSDownloadURL: "https://releases-art-rhcos.svc.ci.openshift.org/art/storage/releases/rhcos-4.4/44.81.202003110027-0/x86_64/rhcos-44.81.202003110027-0-openstack.x86_64.qcow2.gz?sha256=237b9e0af475bf318abbe8d83d5508c2c3d4cca96fdcdb16edace2cc062216d1"

--- Additional comment from Stephen Benjamin on 2020-04-23 15:53:55 UTC ---

rendered template* I meant, of course

--- Additional comment from  on 2020-04-23 17:54:14 UTC ---

proposed fix : https://github.com/openshift/machine-api-operator/pull/568

Comment 12 errata-xmlrpc 2020-06-17 22:26:05 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.