Bug 1830222

Summary: email.FeedParser import error (should be imported from email.feedparser or email.parser)
Product: [Fedora] Fedora Reporter: Oyvind Albrigtsen <oalbrigt>
Component: python-httplib2Assignee: Miro Hrončok <mhroncok>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: rawhideCC: andreas.bierfert, dingyichen, fschwarz, gwync, igor.raits, jspaleta, kevin, mhroncok, pcahyna
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-05-04 15:26:34 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1785415, 1830934, 1830947, 1830949, 1830977, 1830978, 1830986    

Description Oyvind Albrigtsen 2020-05-01 07:37:40 UTC
Description of problem:
In python3-3.8.2-2.fc33.x86_64 email.FeedParser has been renamed to email.feedparser making "import httplib2" fail.

04:56:39 Traceback (most recent call last):
04:56:39   File "gce/fence_gce", line 18, in <module>
04:56:39     import googleapiclient.discovery
04:56:39   File "/usr/lib/python3.8/site-packages/googleapiclient/discovery.py", line 52, in <module>
04:56:39     import httplib2
04:56:39   File "/usr/lib/python3.8/site-packages/httplib2/__init__.py", line 28, in <module>
04:56:39     import email.FeedParser
04:56:39 ModuleNotFoundError: No module named 'email.FeedParser'

# python3
Python 3.8.2 (default, Feb 28 2020, 00:00:00) 
[GCC 10.0.1 20200216 (Red Hat 10.0.1-0.8)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import email.FeedParser
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ModuleNotFoundError: No module named 'email.FeedParser'
>>> import email.feedparser
>>> 

Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
1. Run python3
2. import httplib2
3.

Actual results:
Fails

Expected results:
Succeeds

Additional info:

Comment 1 Gwyn Ciesla 2020-05-01 14:02:16 UTC
Fixed with sed, filed upstream. However it also tries to import httplib which is missing.

Comment 2 Miro Hrončok 2020-05-04 11:32:51 UTC
> Fixed with sed.

Gwyn, there has been no commit from you about this.



Side note: There has been no renaming, the module was always been called email.parser.FeedParser, but there was some internal import that exposed it trough email.FeedParser.

This blocks rebuilds for Python 3.9.

Comment 3 Gwyn Ciesla 2020-05-04 14:31:45 UTC
No, my apologies, I submitted the comment by accident. There's a lot more that needs fixing than simply a sed, it's in the upstream ticket.

Comment 4 Miro Hrončok 2020-05-04 15:00:22 UTC
Looking at the code I guess the python2 folder is getting installed instead of python3 folder.

I believe this commit https://src.fedoraproject.org/rpms/python-httplib2/c/6463ecb14cc627d4a0723ffce927d34702d06020?branch=master has introduced this regression.

Comment 5 Miro Hrončok 2020-05-04 15:01:47 UTC
I'll prep a PR in couple hours (I have a FEESCo meeting now).

Comment 7 Gwyn Ciesla 2020-05-04 15:26:34 UTC
Merged and built, thank you!