Bug 1830395 (CVE-2020-12690)

Summary: CVE-2020-12690 openstack-keystone: OAuth1 request token authorize silently ignores roles parameter
Product: [Other] Security Response Reporter: Laura Pardo <lpardo>
Component: vulnerabilityAssignee: Red Hat Product Security <security-response-team>
Status: CLOSED ERRATA QA Contact:
Severity: high Docs Contact:
Priority: high    
Version: unspecifiedCC: aileenc, bdettelb, chazlett, dbecker, drieden, ggaughan, gmalinko, janstey, jjoyce, jochrist, jschluet, jwon, lbragsta, lhh, lpeer, mburns, mkaplan, nkinder, ntait, oblaut, sclewis, security-response-team, slinaber, tomckay
Target Milestone: ---Keywords: Security
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Keystone 15.0.1, Keystone 16.0.1 Doc Type: If docs needed, set a value
Doc Text:
A flaw was found in Keystone, where it inadvertently provided OAuth1 access tokens to every role assignment the creator had for a project, resulting in giving more permissions and escalated access in role assignments than intended. The greatest impact is on confidentiality.
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-07-22 13:27:38 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1831358, 1831359, 1831360, 1831361, 1832400    
Bug Blocks: 1830398, 1850064    
Attachments:
Description Flags
propossed patch
none
propossed patch
none
propossed patch none

Description Laura Pardo 2020-05-01 19:56:51 UTC
A vulnerability was found in Keystone's OAuth1 Token API. Previously the list of roles provided for an OAuth1 access token were ignored, so when an access token was used to request a keystone token, the keystone token would contain every role assignment the creator had for the project. This results in the provided keystone token having more role assignments than the creator intended, possibly giving unintended escalated access.

Comment 1 Laura Pardo 2020-05-01 20:06:30 UTC
Created attachment 1683827 [details]
propossed patch

Comment 2 Laura Pardo 2020-05-01 20:06:51 UTC
Created attachment 1683828 [details]
propossed patch

Comment 3 Laura Pardo 2020-05-01 20:07:15 UTC
Created attachment 1683829 [details]
propossed patch

Comment 4 msiddiqu 2020-05-01 21:37:17 UTC
References: 
 
https://launchpad.net/bugs/1873290

Comment 12 Nick Tait 2020-05-06 16:37:07 UTC
Created openstack-keystone tracking bugs for this issue:

Affects: openstack-rdo [bug 1832400]

Comment 15 Nick Tait 2020-05-07 19:59:26 UTC
External References:

https://security.openstack.org/ossa/OSSA-2020-005.html

Comment 18 Nick Tait 2020-05-14 01:12:58 UTC
Acknowledgments:

Name: kay (OpenStack)

Comment 19 Michael Kaplan 2020-06-23 13:49:21 UTC
*** Bug 1850063 has been marked as a duplicate of this bug. ***

Comment 20 errata-xmlrpc 2020-07-22 12:40:14 UTC
This issue has been addressed in the following products:

  Red Hat OpenStack Platform 15.0 (Stein)

Via RHSA-2020:3102 https://access.redhat.com/errata/RHSA-2020:3102

Comment 21 errata-xmlrpc 2020-07-22 12:40:22 UTC
This issue has been addressed in the following products:

  Red Hat OpenStack Platform 16.0 (Train)

Via RHSA-2020:3105 https://access.redhat.com/errata/RHSA-2020:3105

Comment 22 Product Security DevOps Team 2020-07-22 13:27:38 UTC
This bug is now closed. Further updates for individual products will be reflected on the CVE page(s):

https://access.redhat.com/security/cve/cve-2020-12690

Comment 23 Jason Shepherd 2021-03-22 00:55:04 UTC
Statement:

Red Hat Quay includes keystone-client, which is not vulnerable to this (server-side) vulnerability.