Bug 183097

Summary:	Review Request: rogue - text-based adventure game
Product:	[Fedora] Fedora	Reporter:	Wart <wart>
Component:	Package Review	Assignee:	John Mahowald <jpmahowald>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	Keywords:	Reopened
Target Milestone:	---	Flags:	kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-08-29 13:06:09 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779

Description Wart 2006-02-26 05:45:02 UTC

Spec Name or Url: http://www.kobold.org/~wart/fedora/rogue.spec
SRPM Name or Url: http://www.kobold.org/~wart/fedora/rogue-5.4.2-1.src.rpm
Description: 
Before DOOM, there were the Dungeons of DOOM.  This is the game that started an entire genre.

Comment 1 Wart 2006-02-26 05:49:30 UTC

rogue is setgid 'games' so that everyone who runs the game can write to the high
score file.  This causes rpmlint to complain:

E: rogue non-standard-dir-perm /var/games/roguelike 0775
E: rogue non-standard-executable-perm /usr/bin/rogue 02755

I am inclined to ignore this.

Comment 2 John Mahowald 2006-03-10 05:05:01 UTC

Good:

- rpmlint checks return:
E: rogue non-standard-dir-perm /var/games/roguelike 0775
E: rogue non-standard-executable-perm /usr/bin/rogue 02755
ignored as per comment 1.

- package meets naming guidelines
- package meets packaging guidelines
- license (BSD) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- .desktop  file
- runs :)

APPROVED

Comment 3 Wart 2006-03-13 05:13:27 UTC

Imported and built.  Thanks!

Comment 4 John Mahowald 2006-08-29 13:06:09 UTC

Assigning to me.

Comment 5 Wart 2007-10-15 18:54:59 UTC

Package Change Request
======================
Package Name: rogue
New Branches: F-8

Comment 6 Kevin Fenzi 2007-10-15 20:37:22 UTC

cvs done.