Bug 1831087

Summary: Storage persistent volume claim form inputs need proper labels
Product: OpenShift Container Platform Reporter: Jessie <jhuff>
Component: Management ConsoleAssignee: Jessie <jhuff>
Status: CLOSED ERRATA QA Contact: Yadan Pei <yapei>
Severity: low Docs Contact:
Priority: unspecified    
Version: 4.5CC: aos-bugs, bpeterse, hasha, jokerman, spadgett, yanpzhan
Target Milestone: ---   
Target Release: 4.5.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-07-13 17:34:48 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Persistent volume claim form error
none
pvcform-error none

Description Jessie 2020-05-04 15:52:11 UTC
Created attachment 1684882 [details]
Persistent volume claim form error

Description of problem:
On the persistent volume claims form, the size inputs need proper labeling and association. The "Size" label has `for="request-size-input"` but there isn't an element with `id="request-size-input". In VO's rotor menu, neither the input or the dropdown have a clear description. The input field currently reads: "required invalid data stepper" and dropdown reads: "GiB collapsed popup menu". These are unclear for an assistive technology user to understand what these elements do.

The current implementation also shows the following axe error:
{
    "data": null,
    "id": "aria-label",
    "impact": "serious",
    "message": "aria-label attribute does not exist or is empty",
    "relatedNodes": [
      {
        "html": "<input class="pf-c-form-control" type="number" step="any" aria-describedby="request-size-help" name="requestSizeValue" required="" value="">"
      }
    ]
  }

The input field should be associated with the above label by adding the correct id (which will make the axe error go away since it will allow screen readers to see the connection between the label and the input) and an aria-label should be added to the dropdown so it's more descriptive.


How reproducible:
You can see this error by using the Axe Chrome Extension.

Steps to Reproduce:
1. Go to the Create Persistent Volume Claim form under Storage: http://localhost:9000/k8s/ns/default/persistentvolumeclaims/~new/form
2. Open developer tools, go to the axe tab, press analyze
3. Click on the issue "Form elements must have labels" for details.

Actual results:
Unclear readout of the size input field and dropdown and incorrect label/input association.

Expected results:
Clear description of what elements do for assistive technology.

Additional info:

Comment 3 Yanping Zhang 2020-05-11 08:55:26 UTC
Checked on ocp 4.5 cluster with payload 4.5.0-0.nightly-2020-05-10-231314.
On create pvc form, using axe to analyze, there is still "Form elements must have labels" error, and no new label is added for input node. Pls refer to the attachment.

Comment 4 Yanping Zhang 2020-05-11 08:56:11 UTC
Created attachment 1687204 [details]
pvcform-error

Comment 5 bpeterse 2020-05-26 13:23:11 UTC
Devs cannot reproduce, can we do one more QE pass?
Thanks!

Comment 6 shahan 2020-05-27 08:38:50 UTC
On create pvc form, using axe to analyze, there is no “Form elements must have labels” error
4.5.0-0.nightly-2020-05-26-193830

Comment 7 errata-xmlrpc 2020-07-13 17:34:48 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2409