Bug 1831376

Summary:	OSP 16.1 \| Overcloud deployment fails when trying to deploy with collectd.
Product:	Red Hat OpenStack	Reporter:	Leonid Natapov <lnatapov>
Component:	collectd	Assignee:	Matthias Runge <mrunge>
Status:	CLOSED DUPLICATE	QA Contact:	Leonid Natapov <lnatapov>
Severity:	urgent	Docs Contact:
Priority:	urgent
Version:	16.1 (Train)	CC:	csibbitt, jbadiapa, lars, lmadsen, mmagr, mrunge, pkilambi, rmccabe
Target Milestone:	beta	Keywords:	Regression, Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-05-18 18:22:46 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Leonid Natapov 2020-05-05 02:44:09 UTC

OSP 16.1 | Overcloud deployment fails when trying to deploy with collectd.

Bug occurs on OSP16.1. OSP16.0 same scenario can be deployed without issues.

Overcloud deployment fails on collectd. I have tried two scenarios that involved collectd.

1.with enable-stf.yaml
2. with qdr-edge-only.yaml and collectd-write-qdr.yaml

Both failed with the same error:


May  5 01:06:35 controller-0 puppet-user[43101]: Error: Evaluation Error: Error while evaluating a Resource Statement, Duplicate declaration: Package[collectd-python] is already declared at (file: /etc/puppet/modules/collectd/manifests/pl
ugin/python.pp, line: 38); cannot redeclare (file: /etc/puppet/modules/tripleo/manifests/profile/base/metrics/collectd.pp, line: 285) (file: /etc/puppet/modules/tripleo/manifests/profile/base/metrics/collectd.pp, line: 285, column: 5) on
node controller-0.redhat.local

Comment 2 Leif Madsen 2020-05-05 14:12:04 UTC

Wonder if the default plugin list is not in sync between versions, and now `python` plugin is effectively being declared twice.

Comment 3 Martin Magr 2020-05-06 09:17:23 UTC

Package[collectd-python] resource has been added with [1]. We need to ass collectd::manage_package: false hiera to THT of collectd composable service.

[1] https://github.com/voxpupuli/puppet-collectd/commit/672452018abefde44f18de9cb75a3102e0745f61#diff-72cdbba755da633a565633bae5731220

Comment 4 Martin Magr 2020-05-06 09:24:43 UTC

Whoops ... s/ass/add/

Comment 6 Matthias Runge 2020-05-14 13:07:04 UTC

After the investigation today, https://bugzilla.redhat.com/show_bug.cgi?id=1831376#c3 is not the fix.

puppet-collectd needs to be patched/fixed to not use requires, if manage_package is set to false.

Comment 7 Matthias Runge 2020-05-14 15:35:41 UTC

Even when setting manage_package: true I am getting:

May 14 15:23:59 puppet-user: Warning: ModuleLoader: module 'collectd' has unresolved dependencies - it will only see those that are resolved. Use 'puppet module list --tree' to see information about modules\\n   (file & line not available)", "<13>May 14 15:23:59 puppet-user: Warning: ModuleLoader: module 'concat' has unresolved dependencies - it will only see those that are resolved. Use 'puppet module list --tree' to see information about modules\\n   (file & line not available)", "<13>May 14 15:24:00 puppet-user: Error: Could not find resource 'Package[collectd]' in parameter 'require' on node compute-0.redhat.local", "+ rc=1", "+ '[' False = false ']'", "+ set -e", "+ '[' 1 -ne 2 -a 1 -ne 0 ']'", "+ exit 1", " attempt(s): 1", "2020-05-14 15:24:03,930 WARNING: 120678 -- Retrying running container: collectd",

basically, that is unchanged between manage_package set to true or false.

Comment 8 Matthias Runge 2020-05-14 16:40:50 UTC

connected to this: https://github.com/openstack/puppet-tripleo/commit/4cefed3c01311a79079434e74150db838d7a9950

Comment 9 Matthias Runge 2020-05-18 18:22:46 UTC

Apparently, this is probably a duplicate of 1834985

*** This bug has been marked as a duplicate of bug 1834985 ***