Bug 1831821
| Summary: | NetworkAttachmentDefinition wizard creates invalid spec for cnv-bridge CNI | |||
|---|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | Petr Horáček <phoracek> | |
| Component: | Console Kubevirt Plugin | Assignee: | Yaacov Zamir <yzamir> | |
| Status: | CLOSED ERRATA | QA Contact: | Guohua Ouyang <gouyang> | |
| Severity: | medium | Docs Contact: | ||
| Priority: | medium | |||
| Version: | 4.4 | CC: | aos-bugs, gouyang, phbailey, yzamir | |
| Target Milestone: | --- | |||
| Target Release: | 4.4.z | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | Doc Type: | No Doc Update | ||
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1832241 (view as bug list) | Environment: | ||
| Last Closed: | 2020-06-23 00:57:24 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | 1832241 | |||
| Bug Blocks: | ||||
Phillip, I have tried to create the needed PR on console myself, but as expected, it went terribly wrong. Would you be so kind and helped me get it into an acceptable shape? Thanks. https://github.com/openshift/console/pull/5290 Original issue found on 4.4 fixing the version Petr, I commented on your PR with what you need to do to fix it. Let me know if that doesn't work for you. Yaacov has already cloned the BZ so we can get it backported. Ping me on Monday and I'll help you with that, as well. ^^ @Petr hi, Philip commented on your PR, p.s. did the comment help / do you prefer our team take the PR ? Phillip, Yaacov, thanks a lot for the offered help! I'm afraid I was too ambitious (the dream of having a PR merged in console) and I would just slow you down. Please take over it if it does not cause you much troubles. > Please take over it if it does not cause you much troubles.
No problems +1
Will take the BZ and keep you updated
p.s.
If you do find some time, feel free to continue this PR or open others, help is appreciated.
Submitted upstream: https://github.com/openshift/console/pull/5427 merged upstream: https://github.com/openshift/console/pull/5427 tested on upstream 4.4 branch with commit ef3268ae549554e51b2a96b8a9771553e23901dd
Now it looks like `{"name":"test","cniVersion":"0.3.1","plugins":[{"type":"cnv-bridge","bridge":"br1","ipam":{}},{"type":"cnv-tuning"}]}`, the bug is fixed.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2020:2580 |
Description of problem: The NetworkAttachmentDefinition wizard in console creates an invalid config for cnv-bridge CNI. The generated config has "plugin" attribute set in the root of the "config". Due to that, the "plugins" list is ignored and the CNI plugin uses defaults for all the attribute. That results in bridge "cni0" created on a node (instead of the bridge specified in the UI). Version-Release number of selected component (if applicable): OCP 4.5 How reproducible: Always Steps to Reproduce: 1. Create cnv-bridge CNI network in the NetworkAttachmentDefinition wizard Actual results: oc get network-attachment-definitions.k8s.cni.cncf.io/via-gui -o jsonpath={.spec.config} | jq { "name": "via-gui", "type": "cnv-bridge", <<<< should not be there "cniVersion": "0.3.1", "plugins": [ { "type": "cnv-bridge", <<< should be only here "bridge": "br99999", "ipam": {} }, { "type": "cnv-tuning" } ] } Expected results: oc get network-attachment-definitions.k8s.cni.cncf.io/via-gui -o jsonpath={.spec.config} | jq { "name": "via-gui", "cniVersion": "0.3.1", "plugins": [ { "type": "cnv-bridge", "bridge": "br99999", "ipam": {} }, { "type": "cnv-tuning" } ] }