Bug 1832170

Summary: Cannot bring up ip6gre tunnel connection via NetworkManager
Product: Red Hat Enterprise Linux 7 Reporter: Vladimir Benes <vbenes>
Component: NetworkManagerAssignee: Beniamino Galvani <bgalvani>
Status: CLOSED ERRATA QA Contact: Desktop QE <desktop-qa-list>
Severity: high Docs Contact:
Priority: unspecified    
Version: 7.9CC: acardace, atragler, bgalvani, dbragalo, desktop-qa-list, fgiudici, fpokryvk, lrintel, ptalbert, pvlasin, rkhan, sukulkar, thaller, till, tpelka, vbenes
Target Milestone: rcKeywords: Regression
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1704308 Environment:
Last Closed: 2020-09-29 20:30:25 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1704308    
Bug Blocks:    
Attachments:
Description Flags
[PATCH] ip-tunnel: set the cloned-mac-address only for L2 tunnel devices none

Comment 6 Beniamino Galvani 2020-05-06 14:56:55 UTC 
Created attachment 1685764 [details]
[PATCH] ip-tunnel: set the cloned-mac-address only for L2 tunnel devices

On RHEL 7.9 there was this kernel commit [1] that started to set a permanent hardware address for L3 tunnels like ipgre and ip6gre. On RHEL7 NM tries to restore the permanent MAC (if any exists) during activation, and this fails for such devices.

I think we should apply the RHEL7-only patch attached to skip setting the MAC on L3 tunnels.

[1] http://git.app.eng.bos.redhat.com/git/rhel7.git/commit/?id=02b67e205e335edfd1e3444e39f94296fd770c69
Comment 8 Thomas Haller 2020-05-06 19:03:02 UTC 
>    On master the default value for cloned-mac-address is 'preserve' and
>    so there is the guarantee that NM never tries to change the MAC for L3
>    tunnels.
>
>    RHEL7 has a downstream patch that changes the default
>    cloned-mac-address to 'permanent'; therefore we have to ensure that
>    the tunnel mode allows it before trying to change the MAC.

Yes, this default makes it more critical, but it's an issue in general. "never tries to change" is not true. As always, it depends on the configuration. "ethernet.cloned-mac-address" should behave sensibly, regardless of what's the default it.


The patch looks god to me, but I think we should not backport to RHEL-7 only.
As always, let's fix the issue on master first, then on nm-1-24 (preferably by cherry-picking), then on nm-1-22, etc.pp.

Maybe on master it doesn't apply exactly the same way. So on master it may need a different solution (or is already fixed).

I think it's important to ensure that every fix in a version is also fixed in all newer versions.
Comment 9 Beniamino Galvani 2020-05-13 08:39:51 UTC 
I've opened a merge request to fix the problem on master:

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/503
Comment 14 Vladimir Benes 2020-05-19 13:37:23 UTC 
test passing now.
Comment 16 errata-xmlrpc 2020-09-29 20:30:25 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: NetworkManager security and bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:4003