Bug 1832828

Summary:	Serial number provided is ignored
Product:	[oVirt] ovirt-engine	Reporter:	Petr Matyáš <pmatyas>
Component:	BLL.Virt	Assignee:	Liran Rotenberg <lrotenbe>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Qin Yuan <qiyuan>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	4.4.0	CC:	bugs, lveyde, qiyuan, rbarry, sbonazzo
Target Milestone:	ovirt-4.4.1	Keywords:	Regression
Target Release:	4.4.1	Flags:	pm-rhel: ovirt-4.4+ pm-rhel: blocker?
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	ovirt-engine-4.4.1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-07-08 08:25:51 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Virt	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Petr Matyáš 2020-05-07 10:53:13 UTC

Description of problem:
If you provide serial number for a VM in edit dialogue it's not used by the VM, it's actually not even used in qemu process and it's not used in any XML dumps in engine log.
The serial that is passed is not Host ID nor VM ID.
The VM has the serial number that is in qemu process serial parameter.

Version-Release number of selected component (if applicable):
ovirt-engine-4.4.0-0.33.master.el8ev.noarch

How reproducible:
always

Steps to Reproduce:
1. set any custom serial number in system tab in edit VM
2. start the VM
3.

Actual results:
the VM will have "random" serial number

Expected results:
the VM should have specified serial number

Additional info:
Serial number provided: 0a223f48-855a-2s1o-1o5k-3c97ce163256
qemu process: ...2-1.0.el8,serial=a07d74b5-431f-40e8-895f-ba5be5b920bd,uuid=11c122fc-e654-41d1-9c... this one is also used in all xml dumps in engine log

Comment 1 Petr Matyáš 2020-05-07 10:58:25 UTC

Actually found out the ID is Host ID of the original host that launched the VM even though the VM was then started on different one.

Comment 2 RHEL Program Management 2020-05-08 00:20:07 UTC

This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.

Comment 3 Qin Yuan 2020-06-03 14:12:29 UTC

Verified with:
ovirt-engine-4.4.1-0.1.el8ev.noarch

Verification steps:
1. Create a VM with default serial number policy, which is 'Cluster default(Host ID)', start VM, check serial number.
2. Stop VM, select 'Vm ID' as the serial number policy in edit dialogue, start VM, check serial number.
3. Stop VM, select 'Custom serial number' as the serial number policy in edit dialogue, and input 0a223f48-855a-2s1o-1o5k-3c97ce163256 as the customized serial number, start VM, check serial number.

Results:
1. When serial number policy is Host ID, the VM's serial number is the uuid of host on which the VM is first running on:

engine log:
2020-06-03 11:21:24,264+03 INFO  [org.ovirt.engine.core.vdsbroker.vdsbroker.DumpXmlsVDSCommand] (EE-ManagedScheduledExecutorService-engineScheduledThreadPool-Thread-15) [] START, DumpXmlsVDSCommand(HostName = host_mixed_2, Params:{hostId='3ea271cf-a3bf-4349-a8ef-74b9b44395db', vmIds='[9e59707a-4e92-4bef-9416-8b0b51e05fed]'}), log id: 40a13da1
...
    <system>
      <entry name='manufacturer'>Red Hat</entry>
      <entry name='product'>RHEL</entry>
      <entry name='version'>8.2-1.0.el8</entry>
      <entry name='serial'>4c4c4544-004c-4210-804e-b7c04f465931</entry>
      <entry name='uuid'>9e59707a-4e92-4bef-9416-8b0b51e05fed</entry>
      <entry name='sku'>8.2.0</entry>
      <entry name='family'>RHV</entry>
    </system>

qemu log:
-smbios 'type=1,manufacturer=Red Hat,product=RHEL,version=8.2-1.0.el8,serial=4c4c4544-004c-4210-804e-b7c04f465931,uuid=9e59707a-4e92-4bef-9416-8b0b51e05fed,sku=8.2.0,family=RHV'

check in vm:
[root@dhcp163-89 ~]# dmidecode |grep "Serial Number"
	Serial Number: 4c4c4544-004c-4210-804e-b7c04f465931

host uuid:
                vds_id                |   vds_name   |            vds_unique_id             
--------------------------------------+--------------+--------------------------------------
 3ea271cf-a3bf-4349-a8ef-74b9b44395db | host_mixed_2 | 4c4c4544-004c-4210-804e-b7c04f465931


2. When serial number policy is 'Vm ID', the VM's serial number is vm id:

engine.log:
2020-06-03 11:48:41,827+03 INFO  [org.ovirt.engine.core.vdsbroker.vdsbroker.DumpXmlsVDSCommand] (EE-ManagedScheduledExecutorService-engineScheduledThreadPool-Thread-52) [] START, DumpXmlsVDSCommand(HostName = host_mixed_2, Params:{hostId='3ea271cf-a3bf-4349-a8ef-74b9b44395db', vmIds='[9e59707a-4e92-4bef-9416-8b0b51e05fed]'}), log id: 59446fe9
...
    <system>
      <entry name='manufacturer'>Red Hat</entry>
      <entry name='product'>RHEL</entry>
      <entry name='version'>8.2-1.0.el8</entry>
      <entry name='serial'>9e59707a-4e92-4bef-9416-8b0b51e05fed</entry>
      <entry name='uuid'>9e59707a-4e92-4bef-9416-8b0b51e05fed</entry>
      <entry name='sku'>8.2.0</entry>
      <entry name='family'>RHV</entry>
    </system>

qemu log:
-smbios 'type=1,manufacturer=Red Hat,product=RHEL,version=8.2-1.0.el8,serial=9e59707a-4e92-4bef-9416-8b0b51e05fed,uuid=9e59707a-4e92-4bef-9416-8b0b51e05fed,sku=8.2.0,family=RHV'

check in VM:
[root@dhcp163-89 ~]# dmidecode |grep "Serial Number"
	Serial Number: 9e59707a-4e92-4bef-9416-8b0b51e05fed


3. When serial number policy is 'Custom serial number', the VM's serial number is the user specified id:

engine log:
2020-06-03 12:05:58,848+03 INFO  [org.ovirt.engine.core.vdsbroker.vdsbroker.DumpXmlsVDSCommand] (EE-ManagedScheduledExecutorService-engineScheduledThreadPool-Thread-75) [] START, DumpXmlsVDSCommand(HostName = host_mixed_2, Params:{hostId='3ea271cf-a3bf-4349-a8ef-74b9b44395db', vmIds='[9e59707a-4e92-4bef-9416-8b0b51e05fed]'}), log id: c8bdf7a
...
    <system>
      <entry name='manufacturer'>Red Hat</entry>
      <entry name='product'>RHEL</entry>
      <entry name='version'>8.2-1.0.el8</entry>
      <entry name='serial'>0a223f48-855a-2s1o-1o5k-3c97ce163256</entry>
      <entry name='uuid'>9e59707a-4e92-4bef-9416-8b0b51e05fed</entry>
      <entry name='sku'>8.2.0</entry>
      <entry name='family'>RHV</entry>
    </system>

qemu log:
-smbios 'type=1,manufacturer=Red Hat,product=RHEL,version=8.2-1.0.el8,serial=0a223f48-855a-2s1o-1o5k-3c97ce163256,uuid=9e59707a-4e92-4bef-9416-8b0b51e05fed,sku=8.2.0,family=RHV'

check in VM:
[root@dhcp163-89 ~]# dmidecode |grep "Serial Number"
	Serial Number: 0a223f48-855a-2s1o-1o5k-3c97ce163256

Comment 4 Sandro Bonazzola 2020-07-08 08:25:51 UTC

This bugzilla is included in oVirt 4.4.1 release, published on July 8th 2020.

Since the problem described in this bug report should be resolved in oVirt 4.4.1 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.