Bug 1833198

Summary:	[machines] Failed to add a disk to a vm by creating a new volume with Physical Disk Device pool
Product:	Red Hat Enterprise Linux 7	Reporter:	Xianghua Chen <xchen>
Component:	cockpit	Assignee:	Katerina Koukiou <kkoukiou>
Status:	CLOSED ERRATA	QA Contact:	Xianghua Chen <xchen>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	7.9	CC:	kkoukiou, mpitt, wshi, ymao, yunyang
Target Milestone:	rc	Keywords:	Extras, Rebase
Target Release:	7.9
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1732303	Environment:
Last Closed:	2020-09-30 07:45:20 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1732303
Bug Blocks:

Comment 1 Xianghua Chen 2020-05-08 03:49:01 UTC

This bug still exist on rhel7.9 with version:
cockpit-machines-195.8-2.el7_9.x86_64

Steps:
1. Prepare a Physical Disk Device pool: pdd-pool and add it in the Storage Pools, format as msdos.
2. Prepare a VM, open the Disks tab, click Add Disk and configure options as following:
Source: Create New
Pool: pdd-pool
Name: test
Size: 1 GiB
3. Click Add 

Actual results:
Error occurs:
Error message: unsupported configuration: unknown volume format type qcow2

Expected results:
Disk can be created successfully.

Comment 3 Martin Pitt 2020-05-18 04:53:54 UTC

Katerina, can you please prepare a backport to the rhel-7.9 branch for this? Thanks!

Comment 4 Martin Pitt 2020-06-02 15:52:47 UTC

Backport landed in rhel-7.9 branch: https://github.com/cockpit-project/cockpit/pull/14154

Comment 8 Martin Pitt 2020-06-05 09:57:45 UTC

Fixed harder in https://github.com/cockpit-project/cockpit/pull/14201 -- we'll do a new build ASAP.

Comment 9 Martin Pitt 2020-06-08 08:24:38 UTC

Fixed in cockpit-195.11-1.el7_9 , updated erratum.

Comment 11 Martin Pitt 2020-06-10 15:25:54 UTC

Katerina landed a fix in our rhel-7.9 backport. She applied it to your test system, does it work now? We'll cut another release/build next Monday.

Comment 12 Martin Pitt 2020-06-10 17:08:10 UTC

Fixed in cockpit-195.12-1.el7_9 , updated erratum. Sorry that this took three attempts!

Comment 14 Xianghua Chen 2020-06-11 09:37:16 UTC

Verified with package:
cockpit-machines-195.12-1.el7_9.x86_64
libvirt-dbus-1.3.0-1.el7.x86_64

Steps:
1. Prepare a Physical Disk Device pool: pdd-pool and add it in the Storage Pools, format as msdos.
2. Prepare a VM, open the Disks tab, click Add Disk and configure options as following:
Source: Create New
Pool: pdd-pool
Name: sdb1
Size: 1 GiB
3. Click Add 
4. Open the Disks tab agian, click Add Disk ,choose the pdd-pool any other value as format(don't click add) and then change back to none, then click add

In step 3 and step 4, the disk can be added successfully.
So verified.

Comment 16 errata-xmlrpc 2020-09-30 07:45:20 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (cockpit bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4085