Bug 1833875

Summary:	[RFE] OCS must-gather should collect PVC information from all namespaces
Product:	[Red Hat Storage] Red Hat OpenShift Container Storage	Reporter:	Prasad Desala <tdesala>
Component:	must-gather	Assignee:	Pulkit Kundra <pkundra>
Status:	CLOSED ERRATA	QA Contact:	Yosi Ben Shimon <ybenshim>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	4.4	CC:	assingh, bkunal, edonnell, hnallurv, jarrpa, madam, ocs-bugs, pkundra, ratamir, sabose
Target Milestone:	---	Keywords:	FutureFeature
Target Release:	OCS 4.5.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-09-15 10:17:01 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Prasad Desala 2020-05-11 06:05:24 UTC

Description of problem (please be detailed as possible and provide log
snippests):
==================================================================================
Why this RFE:
Currently ocs must-gather collects PVCs and Pods info from only openshift-storage namespace for non-LSO and from local-block for LSO. Because of this we don’t get information on the workload pods that Customers create for running their workloads.

What are the Benefits:
It we start collecting this information from all namespaces we can have following benefits, 
- We can get some estimation on the number of PVCs/Pods being used, PVC types, its sizes, rbd/cephfs ratio etc which can help us to replicate and build similar configurations in our tests.
- We may come to know what kind of workload they are running seeing the pvcs/pods names(assuming they name it with app names)

Version of all relevant components (if applicable):
ocs-olm-operator:4.4.0-416.ci

Does this issue impact your ability to continue to work with the product
(please explain in detail what is the user impact)?


Is there any workaround available to the best of your knowledge?


Rate from 1 - 5 the complexity of the scenario you performed that caused this
bug (1 - very simple, 5 - very complex)?


Can this issue reproducible?


Can this issue reproduce from the UI?


If this is a regression, please provide more details to justify this:


Steps to Reproduce:
===================
1) Create a OCS setup.
2) Create PVCs and PODs in namespaces other than openshift-storage.
3) Collect OCS must-gather

Actual results:
===============
ocs must-gather collects only pvc and pods from only openshift-storage namespace for non-LSO and from local-block for LSO.

Expected results:
=================
ocs must-gather should collect pvc and pods info from all namespaces.

Comment 4 Sahina Bose 2020-05-27 13:29:08 UTC

I'm changing the title to reflect Comment 3. Please provide a use case why all pods info is required from ocs-must-gather.

Comment 5 Sahina Bose 2020-05-27 13:30:00 UTC

Could you ack?

Comment 8 Prasad Desala 2020-06-02 06:09:19 UTC

(In reply to Sahina Bose from comment #4)
> I'm changing the title to reflect Comment 3. Please provide a use case why
> all pods info is required from ocs-must-gather.

@sahina @Pulkit Kundra,

We have provided the info and our thoughts in comment6 and comment7.
Request you to take a look.

Comment 9 Michael Adam 2020-06-25 09:05:40 UTC

Bot not adding all ACKs - fixing

Comment 11 Pulkit Kundra 2020-06-29 06:30:38 UTC

Hey Prasad,

Do we want pods of all namespaces or only the user created namespaces?

Comment 12 Prasad Desala 2020-06-30 07:43:37 UTC

(In reply to Pulkit Kundra from comment #11)
> Hey Prasad,
> 
> Do we want pods of all namespaces or only the user created namespaces?

We should collect the pods info from all user created namespaces. 
Also as discussed offline we should be able to collect this info without any additional args to the must gather command.

Comment 13 Jose A. Rivera 2020-07-06 13:22:38 UTC

Gathering Pod information from outside the openshift-storage namespace is beyond our scope and should not be done. 

Gathering PVCs should be limited to OSD PVCs (in openshift-storage) and any Ceph-CSI PVCs.

Comment 19 Yosi Ben Shimon 2020-08-13 11:08:53 UTC

Tested on 4.5.0-0.nightly-2020-08-13-050101
Both OCP and OCS are 4.5

Created a new project and 2 PVC's under that project.
Running the commnad:
$ oc adm must-gather --image=quay.io/rhceph-dev/ocs-must-gather:latest-4.5

and for compaison:
$ oc adm must-gather

the 1st command result with all info including the PVC's from the newly created projcet located in:
<must-gather-local-dir>/must-gather.local.9200014162694556572/quay-io-rhceph-dev-ocs-must-gather-sha256-191e1a9fadc5b379104a64cc6516b8712acaf72f7c1ec31ad80263f5a3ba8128/ceph/pvc_all_namespaces/namespaces/yosi-proj-bz-1833875/core/persistentvolumeclaims

Looks good to me.
Moving to VERIFIED

Comment 21 errata-xmlrpc 2020-09-15 10:17:01 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Red Hat OpenShift Container Storage 4.5.0 bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:3754