Bug 1834219

Summary:	Unable to edit service dialogs
Product:	Red Hat CloudForms Management Engine	Reporter:	Gellert Kis <gekis>
Component:	UI - OPS	Assignee:	Milan Zázrivec <mzazrivec>
Status:	CLOSED ERRATA	QA Contact:	Niyaz Akhtar Ansari <nansari>
Severity:	high	Docs Contact:	Red Hat CloudForms Documentation <cloudforms-docs>
Priority:	high
Version:	5.11.5	CC:	dmetzger, hkataria, mzazrivec, nansari, sigbjorn.lie, simaishi, znemecko
Target Milestone:	GA	Keywords:	ZStream
Target Release:	5.11.7	Flags:	simaishi: cfme-5.11.z+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	5.11.7.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-08-06 14:32:54 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	Bug
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	CFME Core	Target Upstream Version:
Embargoed:

Comment 4 Milan Zázrivec 2020-05-15 14:01:09 UTC

I'm adding proper bug description for the sanity of everyone reading this bug report.

Description of problem:
An error occurs when clicking on a service dialog with tag
control in an explorer tree.

Version-Release number of selected component (if applicable):
CFME 5.11.5

How reproducible:
Always

Steps to reproduce:
1. Automation > Automate > Customization > Service Dialogs
2. Create a new dialog, add just one field: Tag Control, select a valid category
3. Save the service dialog
4. Click on the newly created dialog in explorer tree
5. See the following error in application logs:

FATAL -- : Error caught: [ActionView::Template::Error] private method `multiselect?' called for #<DialogFieldTagControl:0x00007ff8c0337848>
.rbenv/versions/2.5.5/lib/ruby/gems/2.5.0/gems/activemodel-5.1.7/lib/active_model/attribute_methods.rb:429:in `method_missing'
manageiq-ui-classic.ivanchuk/app/views/miq_ae_customization/_dialog_sample.html.haml:98
...

Actual results:
The error above.

Expected results:
No error, the explorer tree click should work nicely.

Additional info:
The issue is currently present in 5.11 only, it's fixed in master with
https://github.com/ManageIQ/manageiq/pull/19696 and the true fix here
is to backport the PR to ivanchuk.

Comment 5 Milan Zázrivec 2020-05-15 14:02:12 UTC

https://github.com/ManageIQ/manageiq/pull/19696

Comment 6 CFME Bot 2020-06-18 20:00:20 UTC

New commit detected on ManageIQ/manageiq/ivanchuk:

https://github.com/ManageIQ/manageiq/commit/2bfe6d2aea2a2f2716e744ba847532a7261ee021
commit 2bfe6d2aea2a2f2716e744ba847532a7261ee021
Author:     Brandon Dunne <bdunne>
AuthorDate: Mon Jan 13 19:24:08 2020 +0000
Commit:     Satoe Imaishi <simaishi>
CommitDate: Thu Jun 18 19:55:08 2020 +0000

    Merge pull request #19696 from himdel/dialog-tag-multi

    DialogFieldTagControl - don't add <None> for multiselects

    (cherry picked from commit 9ce9b3df7565a7fe4ad64494e348841f4ada98e0)

    https://bugzilla.redhat.com/show_bug.cgi?id=1834219

 app/models/dialog_field_tag_control.rb | 6 +-
 spec/models/dialog_field_tag_control_spec.rb | 19 +-
 2 files changed, 21 insertions(+), 4 deletions(-)

Comment 10 errata-xmlrpc 2020-08-06 14:32:54 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Critical: CloudForms 5.0.7 bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:3358