Bug 1834231

Summary:	Review Request: ursa-major - fix install failure on Fedora 32
Product:	[Fedora] Fedora	Reporter:	Yuming Zhu <yzhu>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	32	CC:	decathorpe, package-review, qwan
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-05-11 11:32:36 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	177841, 1834130

Description Yuming Zhu 2020-05-11 10:52:04 UTC

Spec URL: https://github.com/azhuzhu/rpm-usra-major/blob/f32/ursa-major.spec
SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/2926/44362926/ursa-major-0.4.1-2.fc32.src.rpm
Description: this PR is to fix the failure caused by the lack of deps - BZ#1834130
Fedora Account System Username: julian8628
PR: https://src.fedoraproject.org/rpms/ursa-major/pull-request/5

Comment 1 Yuming Zhu 2020-05-11 10:55:34 UTC

This is my first request of review and I need to be sponsored, as I'm now the maintainer of ursa-major.

Comment 2 Yuming Zhu 2020-05-11 10:58:48 UTC

cc @qwan for review

Comment 3 Fabio Valentini 2020-05-11 11:25:29 UTC

Since this package already exists and you're already its maintainer, opening a Review Request (which is for new packages) is not the right avenue to do this, and you don't need a sponsor, since you're obviously already in the packager group.

For doing Pull Requests, I suggest going to https://src.fedoraproject.org/rpms/ursa-major and fork the package.
Do your changes in your fork, and then open a Pull Request for them, so somebody else can review the changes.

But I see you've already done that? https://src.fedoraproject.org/rpms/ursa-major/pull-request/5

I'm confused.

Comment 4 Qixiang Wan 2020-05-11 11:32:36 UTC

(In reply to Fabio Valentini from comment #3)
> Since this package already exists and you're already its maintainer, opening
> a Review Request (which is for new packages) is not the right avenue to do
> this, and you don't need a sponsor, since you're obviously already in the
> packager group.

Yep, review request is the workflow for onboarding a new package, I'm going to close this. Yuming is the new maintainer of ursa-major but he is not in packager group, so I can't give the package to him, I'll contact him for this.

Comment 5 Yuming Zhu 2020-05-11 11:55:12 UTC

(In reply to Fabio Valentini from comment #3)
> Since this package already exists and you're already its maintainer, opening
> a Review Request (which is for new packages) is not the right avenue to do
> this, and you don't need a sponsor, since you're obviously already in the
> packager group.
> 
> For doing Pull Requests, I suggest going to
> https://src.fedoraproject.org/rpms/ursa-major and fork the package.
> Do your changes in your fork, and then open a Pull Request for them, so
> somebody else can review the changes.
> 
> But I see you've already done that?
> https://src.fedoraproject.org/rpms/ursa-major/pull-request/5
> 
> I'm confused.

Yes, I'm able to fork the repo, but because I'm not in packager group, I cannot push commits into either my fork or upstream repo, I guess

Thanks!