Bug 1834523

Summary:	Edit VM -> Enable Smartcard sharing does not stick when VM is running
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	amashah
Component:	ovirt-engine	Assignee:	Lucia Jelinkova <ljelinko>
Status:	CLOSED ERRATA	QA Contact:	Qin Yuan <qiyuan>
Severity:	high	Docs Contact:
Priority:	high
Version:	4.3.9	CC:	ahadas, bpelled, ljelinko, mavital, michal.skrivanek, pelauter
Target Milestone:	ovirt-4.4.1
Target Release:	4.4.1
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	ovirt-engine-4.4.1.5	Doc Type:	Bug Fix
Doc Text:	Previously, adding or removing a smart card to a running virtual machine did not work. The current release fixes this issue. When you add or remove a smart card, it saves this change to the virtual machine's next run configuration. In the Administration Portal, the virtual machine indicates that a next run configuration exists, and lists "Smartcard" as a changed field. When you restart the virtual machine, it applies the new configuration to the virtual machine.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-08-04 13:22:49 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Virt	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description amashah 2020-05-11 20:39:42 UTC

Description of problem:
Edit a running VM, enable Smartcard sharing does not work.

Version-Release number of selected component (if applicable):
4.3.9

How reproducible:
100%

Steps to Reproduce:
1. Edit a running VM, enable Smartcard sharing
2. Check VmDevices tab, smartcard is not there

Actual results:
Smartcard is not enabled.

Expected results:
Smartcard should be enabled.

Additional info:
Even if VM is powered down/up it does not enable Smartcard, but the UI box still remains checked. 

Workaround: Shutdown the VM, disable Smartcard sharing, enable it back again, then boot the VM back up.

Comment 5 Qin Yuan 2020-07-08 08:22:59 UTC

Verified with:
ovirt-engine-4.4.1.7-0.3.el8ev.noarch

Steps and results:
1. Edit a running VM, enable Smartcard:
   1) there is a next run configuration indication on the VM list page, Smartcard is listed as one of the pending virtual machine changes.
   2) Smartcard is not added on Vm Devices tab before restart.

2. Restart the VM:
   1) Smartcard is added on Vm Devices tab.
   2) check dumpxml, smartcard is added
    <smartcard mode='passthrough' type='spicevmc'>
      <alias name='ua-b0370c13-c055-4629-8c4b-ec4c0e6475bb'/>
      <address type='ccid' controller='0' slot='0'/>
    </smartcard>

3. Edit the running VM, disable Smartcard:
   1) there is a next run configuration indication on the VM list page, Smartcard is listed as one of the pending virtual machine changes.
   2) Smartcard is not removed on Vm Devices tab before restart.

4. Restart the VM:
   1) Smartcard is removed on Vm Devices tab.
   2) check dumpxml, there is no smartcard device.

5. Update an instant type with enabling Smartcard, succeeded.

6. Update an instant type with disabling Smartcard, succeeded.

Comment 14 errata-xmlrpc 2020-08-04 13:22:49 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: RHV Manager (ovirt-engine) 4.4 security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:3247