Bug 1835302

Summary:	Review Request: nodejs-pg-protocol - The postgres client/server binary protocol
Product:	[Fedora] Fedora	Reporter:	Tom Hughes <tom>
Component:	Package Review	Assignee:	Robert-André Mauchin 🐧 <eclipseo>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	eclipseo, package-review
Target Milestone:	---	Flags:	eclipseo: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-06-24 14:24:55 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	956806, 1835288

Description Tom Hughes 2020-05-13 15:04:35 UTC

Spec URL: https://tomh.fedorapeople.org//nodejs-pg-protocol.spec
SRPM URL: https://tomh.fedorapeople.org//nodejs-pg-protocol-1.2.3-1.fc32.src.rpm

Description:
The postgres client/server binary protocol, implemented in TypeScript.

Comment 1 Tom Hughes 2020-05-13 15:05:52 UTC

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=44450368

Comment 2 Robert-André Mauchin 🐧 2020-06-24 12:24:11 UTC

 - Bump to 1.2.4

 - Build error:

+ /usr/bin/node -e 'require('\''./'\'')'
/var/tmp/rpm-tmp.BuwxTu: line 33: /usr/bin/node: No such file

   Add:

BuildRequires:  nodejs(engine)


This is due to nodejs-packaging dropping the nodejs engine as a Requires 20 days ago: https://src.fedoraproject.org/rpms/nodejs-packaging/c/021f0badabbe076a6e869e2ebdedfbcb7c2e1ea8?branch=master


 - License ok
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved. Please fix the aforementioned issue before import.

Comment 3 Tom Hughes 2020-06-24 12:43:58 UTC

Hmm dropping that require means the Node.js packaging guidelines are going to need fixing to tell people to require nodejs as well as nodejs-packaging...

Comment 4 Gwyn Ciesla 2020-06-24 14:08:46 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-pg-protocol