Bug 1835640

Can you run remote viewer again, with extra debug messages and attach the logs here?

$ REST_DEBUG=proxy G_MESSAGES_DEBUG=all remote-viewer console.vv

Thank you.

This is not supported. See https://access.redhat.com/documentation/en-us/red_hat_virtualization/4.4-beta/html/technical_reference/storage_domain_types1
ISO images only to ISO domain.

I don't agree. Uploading ISO images to Data domains is supported. ISO domains are being deprecated in RHV 4.4:
https://access.redhat.com/documentation/en-us/red_hat_virtualization/4.4-beta/html/release_notes/deprecated_features_rhv

It's deprecated since RHV 4.2:
https://access.redhat.com/documentation/en-us/red_hat_virtualization/4.2/html/release_notes/deprecated_features_rhv

(In reply to Juan Orti Alcaine from comment #3)
> I don't agree. Uploading ISO images to Data domains is supported. ISO
> domains are being deprecated in RHV 4.4:
> https://access.redhat.com/documentation/en-us/red_hat_virtualization/4.4-
> beta/html/release_notes/deprecated_features_rhv
> 
> It's deprecated since RHV 4.2:
> https://access.redhat.com/documentation/en-us/red_hat_virtualization/4.2/
> html/release_notes/deprecated_features_rhv


From the document it is actually still supported, not being removed in 4.4 just yet.

There are explicit checks in virt-viewer code for the storage domain type, I will propose a patch to expand it to data storage as well.

diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c
index dc6ecf4..c31c93f 100644
--- a/src/ovirt-foreign-menu.c
+++ b/src/ovirt-foreign-menu.c
@@ -661,8 +661,8 @@ static gboolean storage_domain_validate(OvirtForeignMenu *menu G_GNUC_UNUSED,

     g_object_get(domain, "name", &name, "type", &type, "state", &state, NULL);

-    if (type != OVIRT_STORAGE_DOMAIN_TYPE_ISO) {
-        g_debug("Storage domain '%s' type is not ISO", name);
+    if (type != OVIRT_STORAGE_DOMAIN_TYPE_ISO && type != OVIRT_STORAGE_DOMAIN_TYPE_DATA) {
+        g_debug("Storage domain '%s' type is not ISO or DATA", name);
         ret = FALSE;
     }

Patch has been merged upstream.

Test with new build: 
virt-viewer-9.0-1.el8.x86_64

RHV version: Software Version:4.3.10-0.2.el7

Steps:
1. Prepare a RHV 4.3 test environment which has no ISO storage domain attached, then Upload an ISO to a Data Storage Domain

1.1 Click Storage → Select Data domain  → Disks.
1.2 Select Start from the Upload menu.
1.3 Click Choose File and select the ISO file to upload.
1.4 Fill in the Disk Options fields.
1.5 Click OK. 

Name of the ISO is: RHEL-8.2.0-20200404.0-BaseOS-x86_64-boot.iso
 
2. Connect to a SPICE console: 
$ REST_DEBUG=proxy G_MESSAGES_DEBUG=all remote-viewer console.vv

3. Click on File -> Change CD

Result:
I get the error: "Could not find ISO file collection", it's the same with Comment 0.

Log file: $ REST_DEBUG=proxy G_MESSAGES_DEBUG=all remote-viewer console.vv |& tee >remote-viewer.log

@Eduardo, please help me have a look of my steps, my rhv server version is 4.3, will it affect my testing, thanks.

Created attachment 1696274 [details]
log for virt-viewer-9.0-1.el8

(In reply to zhoujunqin from comment #9)
> Test with new build: 
> virt-viewer-9.0-1.el8.x86_64
> 
> RHV version: Software Version:4.3.10-0.2.el7
> 
> Steps:
> 1. Prepare a RHV 4.3 test environment which has no ISO storage domain
> attached, then Upload an ISO to a Data Storage Domain
> 
> 1.1 Click Storage → Select Data domain  → Disks.
> 1.2 Select Start from the Upload menu.
> 1.3 Click Choose File and select the ISO file to upload.
> 1.4 Fill in the Disk Options fields.
> 1.5 Click OK. 
> 
> Name of the ISO is: RHEL-8.2.0-20200404.0-BaseOS-x86_64-boot.iso
>  
> 2. Connect to a SPICE console: 
> $ REST_DEBUG=proxy G_MESSAGES_DEBUG=all remote-viewer console.vv
> 
> 3. Click on File -> Change CD
> 
> Result:
> I get the error: "Could not find ISO file collection", it's the same with
> Comment 0.
> 
> Log file: $ REST_DEBUG=proxy G_MESSAGES_DEBUG=all remote-viewer console.vv
> |& tee >remote-viewer.log
> 

Confirmed, this requires changes on the libgovirt code as well. I will check if we still can make on time for 8.3.

> @Eduardo, please help me have a look of my steps, my rhv server version is
> 4.3, will it affect my testing, thanks.

4.3 version should be ok. Don't worry.

(In reply to Eduardo Lima (Etrunko) from comment #14)
> (In reply to zhoujunqin from comment #9)
> > Test with new build: 
> > virt-viewer-9.0-1.el8.x86_64
> > 
> > RHV version: Software Version:4.3.10-0.2.el7
> > 
> > Steps:
> > 1. Prepare a RHV 4.3 test environment which has no ISO storage domain
> > attached, then Upload an ISO to a Data Storage Domain
> > 
> > 1.1 Click Storage → Select Data domain  → Disks.
> > 1.2 Select Start from the Upload menu.
> > 1.3 Click Choose File and select the ISO file to upload.
> > 1.4 Fill in the Disk Options fields.
> > 1.5 Click OK. 
> > 
> > Name of the ISO is: RHEL-8.2.0-20200404.0-BaseOS-x86_64-boot.iso
> >  
> > 2. Connect to a SPICE console: 
> > $ REST_DEBUG=proxy G_MESSAGES_DEBUG=all remote-viewer console.vv
> > 
> > 3. Click on File -> Change CD
> > 
> > Result:
> > I get the error: "Could not find ISO file collection", it's the same with
> > Comment 0.
> > 
> > Log file: $ REST_DEBUG=proxy G_MESSAGES_DEBUG=all remote-viewer console.vv
> > |& tee >remote-viewer.log
> > 
> 
> Confirmed, this requires changes on the libgovirt code as well. I will check
> if we still can make on time for 8.3.
> 
> > @Eduardo, please help me have a look of my steps, my rhv server version is
> > 4.3, will it affect my testing, thanks.
> 
> 4.3 version should be ok. Don't worry.

Got it, thanks @Eduardo.

Hi Eduardo Lima,
Sorry for the late reply, I am just back from the Chinese Dragon Boat Festival holiday.

I test with latest virt-viewer and libgovirt versions：
virt-viewer-9.0-3.el8.x86_64
libgovirt-0.3.7-3.el8.x86_64

RHV version: Software Version:4.3.10-0.2.el7


Steps: 
Test scenario-1: No ISO storage domain active in the data center.

1.1 Prepare a RHV 4.3 test environment which has no ISO storage domain attached, then Upload an ISO to a Data Storage Domain

1.1.1 Click Storage → Select Data domain  → Disks.
1.1.2 Select Start from the Upload menu.
1.1.3 Click Choose File and select the ISO file to upload.
1.1.4 Fill in the Disk Options fields.
1.1.5 Click OK. 

Name of the ISO is: RHEL-8.3.0-20200616.0-BaseOS-x86_64-boot.iso
 
1.2 Connect to a SPICE console: 
$ REST_DEBUG=proxy G_MESSAGES_DEBUG=all remote-viewer console.vv

1.3 Click on File -> Change CD

Result: 
1.3.1 The image file from DATA storage domain was showed.
1.3.2 Select the image "RHEL-8.3.0-20200616.0-BaseOS-x86_64-boot.iso" to attach to the vm.
-> Failed to update cdrom resource with error: Operation Failed: [Drive image file could not be found]
-> Click "Close" button, then remote-viewer application crashed.

So I think the bug is not fully fixed, please help check, thanks.

Test scenario-2: Data center in which the VM is located has both ISO and DATA storage domains.

2.1 Prepare ISO images in both ISO and DATA storage domains.
iso_domain: 
RHEL-8.2.0-20200404.0-BaseOS-x86_64-boot.iso
RHV-toolsSetup_4.3_11.iso 
RHV-toolsSetup_4.3_12.iso  
rhv-tools-setup.iso

Data_domain: Same with Step1.1
RHEL-8.3.0-20200616.0-BaseOS-x86_64-boot.iso

2.2 Connect to a SPICE console: 
$ REST_DEBUG=proxy G_MESSAGES_DEBUG=all remote-viewer console.vv

2.3 Click on File -> Change CD

Result: 

2.3.1 remote-viewer application will only show the .iso files from the ISO domain, the same way it was doing before.
2.3.2 ISO files can be attached/detached to/from the vm successfully.

@Eduardo, Please help check test scenario-1, thanks.

Created attachment 1699020 [details]
log for virt-viewer-9.0-3.el8.x86_64

Refer to comment 17, the bug issue is not fully fixed, I move the bug status from ON_QA to ASSIGNED, thanks.

I am wondering if this is not a duplicate of this old RHV BZ#1589763 in some way.

Hi Marina, it's not the same bug. This one is about the SPICE client virt-viewer not looking into the Data domains for ISOs.

(In reply to comment #26 and comment #27)

Likely this bug depends on bug 1589763.

(In reply to Uri Lublin from comment #28)
> (In reply to comment #26 and comment #27)
> 
> Likely this bug depends on bug 1589763.

You are correct,the same error described on that bug happens with virt-viewer. The support for DATA domains is already implemented, but it is not possible to validate the solution at the moment.

Created attachment 1741703 [details]
debug log when test rhv4.4

Try to verify this bug with the latest build:
virt-viewer-9.0-11.el8.x86_64

Steps:
1. Upload "RHEL-9.0.0-20210421.d.2-BaseOS-x86_64-boot.iso" to the Data Domain - "nfs_data"

2. Add some images to ISO Domain - iso_domain
[xxx-11111111-1111-1111-1111-111111111111]# ls
en_windows_10_business_editions_version_21h1_x64_dvd_ec5a76c1.iso 
virtio-win-1.9.17-4.el8_4.iso
en_windows_server_2019_updated_may_2020_x64_dvd_5651846f.iso
virtio-win-prewhql-0.1-202.iso



Test scenario-1: Enable ISO Domain and DATA domain together
1.1 Use remote-viewer to connect to console.vv file directly, then click "Change CD"
Test result: Only images in ISO Domain list here, track in Bug 1998386

Test scenario-2: Disable ISO Domain by changing it to Maintenance status
2.1 Use remote-viewer to connect to console.vv file directly, then click "Change CD"
Test result: Only images in the DATA Domain list here


[Negative Testing]Test scenario-3: Remove all images from Data Domain and ISO domain.
3.1 Use remote-viewer to connect to console.vv file directly, then click "Change CD"
Test result: An error message prompts: "Failed to fetch CD names", then I can click "Close" to exit, it's as expected.

Summary - All results are as expected, so I move this bug from ON_QA to VERIFIED status, thanks.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (virt-viewer bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:4165