Bug 1836442

Summary:	CRI-O: Signature verification incorrectly uses mirror’s references
Product:	OpenShift Container Platform	Reporter:	Miloslav Trmač <mitr>
Component:	Containers	Assignee:	Peter Hunt <pehunt>
Status:	CLOSED ERRATA	QA Contact:	weiwei jiang <wjiang>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	4.2.0	CC:	aos-bugs, dkaylor, dornelas, dwalsh, jokerman, lsm5, nagrawal, pehunt, tsweeney
Target Milestone:	---
Target Release:	4.5.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	cri-o-1.18.1-10.dev.rhaos4.5.git179ebfc.el8	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-07-13 17:39:31 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1186913

Description Miloslav Trmač 2020-05-15 21:58:11 UTC

This bug was initially created as a copy of Bug #1829061

c/image/docker.newImageSource, when using mirrors, creates an ImageReference with a types.ImageReference pointing at the mirror, with no record of the primary location. This breaks signature verification, which ultimately uses ImageSource.Reference() to decide what to verify the signature against.

Comment 2 Tom Sweeney 2020-05-18 18:31:57 UTC

Assigning to Lokesh as I think he has everything he needs for packaging purposes.

Comment 9 Peter Hunt 2020-05-22 19:10:51 UTC

pr for 4.5 attached

Comment 11 Peter Hunt 2020-05-28 21:23:11 UTC

infra issues have caused CI to not cooperating, causing the merging of this PR to delay. I will address in the next sprint

Comment 16 Peter Hunt 2020-06-16 17:29:23 UTC

attached PR is merged

Comment 23 errata-xmlrpc 2020-07-13 17:39:31 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2409