Bug 1836768

I made fixes.

Here is the SRPM: https://download.copr.fedorainfracloud.org/results/duck/osas-infra-team-rpm-repo-devel/fedora-rawhide-x86_64/01394846-postfix-mta-sts-resolver/postfix-mta-sts-resolver-0.8.2-1.fc33.src.rpm

And build log: https://copr.fedorainfracloud.org/coprs/duck/osas-infra-team-rpm-repo-devel/build/1394846/

Final build, which is now is used in production: https://copr.fedorainfracloud.org/coprs/duck/osas-infra-team-rpm-repo-devel/build/1398867/

 - BuildRequires:  systemd

Use BuildRequires:  systemd-rpm-macros for anything newer than PEPL7

 - Not needed:

%{?systemd_requires}

 - Man pages must not be installed as %doc:

%if 0%{?fedora} || 0%{?rhel} < 8
%doc %{_mandir}/man*/*
%endif


Also why no EPEL8 support?

 - %{_localstatedir}/lib → %{_sharedstatedir}

 - Bump to release 1.0.0

 - use install -p to keep timestamps

 - Why is mta-sts-daemon.yml 0640 instead of 0644?

 - Remove shebangs in %prep:

postfix-mta-sts-resolver.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/postfix_mta_sts_resolver/__main__.py 644 /usr/bin/env python3
postfix-mta-sts-resolver.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/postfix_mta_sts_resolver/daemon.py 644 /usr/bin/env python3


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "Expat License". 62 files have unknown
     license. Detailed output of licensecheck in
     /home/bob/packaging/review/postfix-mta-sts-resolver/review-postfix-
     mta-sts-resolver/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 5 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: systemd_post is invoked in %post, systemd_preun in %preun, and
     systemd_postun in %postun for Systemd service files.
     Note: Systemd service file(s) in postfix-mta-sts-resolver
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: Uses parallel make %{?_smp_mflags} macro.
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[!]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: postfix-mta-sts-resolver-0.8.2-1.fc33.noarch.rpm
          postfix-mta-sts-resolver-0.8.2-1.fc33.src.rpm
postfix-mta-sts-resolver.noarch: W: spelling-error %description -l en_US linei -> line, lines, linen
postfix-mta-sts-resolver.noarch: W: spelling-error %description -l en_US socketmap -> socket map, socket-map, socket
postfix-mta-sts-resolver.noarch: W: non-standard-gid /etc/mta-sts-daemon.yml mta-sts
postfix-mta-sts-resolver.noarch: E: non-readable /etc/mta-sts-daemon.yml 640
postfix-mta-sts-resolver.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/postfix_mta_sts_resolver/__main__.py 644 /usr/bin/env python3
postfix-mta-sts-resolver.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/postfix_mta_sts_resolver/daemon.py 644 /usr/bin/env python3
postfix-mta-sts-resolver.noarch: W: non-standard-uid /var/lib/mta-sts mta-sts
postfix-mta-sts-resolver.noarch: W: non-standard-gid /var/lib/mta-sts mta-sts
postfix-mta-sts-resolver.src: W: spelling-error %description -l en_US linei -> line, lines, linen
postfix-mta-sts-resolver.src: W: spelling-error %description -l en_US socketmap -> socket map, socket-map, socket
2 packages and 0 specfiles checked; 3 errors, 7 warnings.

Thanks Robert-André for the review, for some reason I missed the notification and just saw it today.

I made changes following your recommendation and the build can be seen here: https://copr.fedorainfracloud.org/coprs/duck/osas-infra-team-rpm-repo/build/1618502/

As for the configuration file permissions, this is dues to potentially containing backend credentials.

OK, package approved.

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/postfix-mta-sts-resolver

Package is available in repos