Bug 1836769

Summary:	Review Request: perl-Metrics-Any - Abstract collection of monitoring metrics
Product:	[Fedora] Fedora	Reporter:	Emmanuel Seyman <emmanuel>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-05-31 12:18:59 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1836770

Description Emmanuel Seyman 2020-05-18 05:55:30 UTC

Spec URL: http://people.parinux.org/~seyman/fedora/perl-Metrics-Any/perl-Metrics-Any.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Metrics-Any/perl-Metrics-Any-0.05-1.fc32.src.rpm
Description:
Provides a central location for modules to report monitoring metrics, such
as counters of the number of times interesting events have happened, and
programs to collect up and send those metrics to monitoring services.

Fedora Account System Username: eseyman

Comment 1 Jitka Plesnikova 2020-05-18 08:06:56 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok
TODO: Please add version to BR
      - perl(List::Util) >= 1.29

$ rpm -qp --requires perl-Metrics-Any-0.05-1.fc33.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(base)
      1 perl(Carp)
      1 perl(List::Util) >= 1.29
      1 perl(Metrics::Any::Adapter)
      1 perl(Metrics::Any::Adapter::File)
      1 perl(Metrics::Any::Collector)
      1 perl(:MODULE_COMPAT_5.30.2)
      1 perl(overload)
      1 perl(strict)
      1 perl(:VERSION) >= 5.10.0
      1 perl(warnings)
Binary requires are Ok.

$ rpm -qp --provides perl-Metrics-Any-0.05-1.fc33.noarch.rpm | sort | uniq -c
      1 perl(Metrics::Any) = 0.05
      1 perl-Metrics-Any = 0.05-1.fc33
      1 perl(Metrics::Any::Adapter) = 0.05
      1 perl(Metrics::Any::Adapter::File) = 0.05
      1 perl(Metrics::Any::Adapter::Null) = 0.05
      1 perl(Metrics::Any::Adapter::Stderr)
      1 perl(Metrics::Any::Adapter::Tee) = 0.05
      1 perl(Metrics::Any::Adapter::Test) = 0.05
      1 perl(Metrics::Any::Collector) = 0.05
Binary provides are Ok.

$ rpmlint ./perl-Metrics-Any*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

Please consider fixing 'TODO' items.

Resolution:
Approved

Comment 2 Emmanuel Seyman 2020-05-18 08:27:24 UTC

Thank you for the review, Jitka.
I've requested the git repository (https://pagure.io/releng/fedora-scm-requests/issue/25067)

Comment 3 Igor Raits 2020-05-18 10:02:32 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Metrics-Any

Comment 4 Emmanuel Seyman 2020-05-31 12:18:59 UTC

Package has been added to rawhide and updates have been released for Fedora 32 and 31.