Bug 1836770

Summary:	Review Request: perl-Test-Metrics-Any - Assert that code produces metrics via Metrics::Any
Product:	[Fedora] Fedora	Reporter:	Emmanuel Seyman <emmanuel>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-05-31 12:19:55 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1836769
Bug Blocks:	1831831

Description Emmanuel Seyman 2020-05-18 05:57:09 UTC

Spec URL: http://people.parinux.org/~seyman/fedora/perl-Test-Metrics-Any/perl-Test-Metrics-Any.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Test-Metrics-Any/perl-Test-Metrics-Any-0.01-1.fc32.src.rpm
Description:
This test module helps write unit tests which assert that the code under
test reports metrics via Metrics::Any.

Fedora Account System Username: eseyman

Comment 1 Jitka Plesnikova 2020-05-18 10:21:06 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires 
FIX: perl(Test::Builder::Module) is listed twice. The second occurrence
     should be replaced by perl(Test::Builder::Tester).

$ rpm -qp --requires perl-Test-Metrics-Any-0.01-1.fc33.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(base)
      1 perl(Metrics::Any::Adapter)
      1 perl(Metrics::Any::Adapter::Test)
      1 perl(:MODULE_COMPAT_5.30.2) 
      1 perl(strict)
      1 perl(Test::Builder::Module)
      1 perl(warnings)
Binary requires are Ok.

$ rpm -qp --provides perl-Test-Metrics-Any-0.01-1.fc33.noarch.rpm | sort | uniq -c
      1 perl(Test::Metrics::Any) = 0.01
      1 perl-Test-Metrics-Any = 0.01-1.fc33
      1 perl(Test::Metrics::Any::_predicate)
Binary provides are Ok.
TODO: Consider to filter provide perl(Test::Metrics::Any::_predicate)

$ rpmlint ./perl-Test-Metrics-Any*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

Please correct all 'FIX' issues and consider fixing 'TODO' items.

Resolution:
Approved

Comment 2 Emmanuel Seyman 2020-05-18 14:21:17 UTC

Thank you for the review, Jitka. I've implement both the FIX and the TODO.

Spec URL: http://people.parinux.org/~seyman/fedora/perl-Test-Metrics-Any/perl-Test-Metrics-Any.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Test-Metrics-Any/perl-Test-Metrics-Any-0.01-2.fc32.src.rpm

I've also requested the repository.

Comment 3 Gwyn Ciesla 2020-05-18 15:46:47 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Test-Metrics-Any

Comment 4 Emmanuel Seyman 2020-05-31 12:19:55 UTC

Package has been added to rawhide and updates have been released for Fedora 32 and 31.