Bug 1836797

Summary: validation framework: openstack tripleo validator history command is missing
Product: Red Hat OpenStack Reporter: Jad Haj Yahya <jhajyahy>
Component: python-tripleoclientAssignee: Gaël Chamoulaud <gchamoul>
Status: CLOSED ERRATA QA Contact: David Rosenfeld <drosenfe>
Severity: high Docs Contact:
Priority: urgent    
Version: 16.1 (Train)CC: cjeanner, gchamoul, hbrock, jjoyce, jschluet, jslagle, mbarnett, mburns, sclewis, slinaber, tvignaud
Target Milestone: rcKeywords: Triaged
Target Release: 16.1 (Train on RHEL 8.2)   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: python-tripleoclient-12.3.2-0.20200615103426.6f877f6.el8ost Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-07-29 07:52:55 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1850341, 1850347    
Bug Blocks:    

Description Jad Haj Yahya 2020-05-18 07:54:39 UTC
Description of problem:
openstack tripleo validator history command is missing

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. openstack tripleo validator --help
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Cédric Jeanneret 2020-06-15 07:18:18 UTC
We're missing one patch in both stein and osp-16.1 branches. It's in Gate upstream as of now. It will add the 2 missing commands, "history" and "show".

Note: it might be pushed as a z-stream, we had some issues with the upstream part and we wanted to get a full green zuul|gate there before merging the downstream patch.

Comment 2 Cédric Jeanneret 2020-06-15 11:54:58 UTC
(osp-16.1 in blocker-only mode, need to push to the -patches instead of -trunk-patches branch)

Comment 5 Cédric Jeanneret 2020-06-18 08:43:22 UTC
And we have a built! yay!

Comment 9 Jad Haj Yahya 2020-06-24 06:01:26 UTC
Running validation and showing history ends up with Tracback:

    openstack tripleo validator run --validation containerized-undercloud-docker
    /usr/lib/python3.6/site-packages/tripleoclient/v1/tripleo_validator.py:437: ResourceWarning: unclosed file <_io.BufferedReader name=7>
      gathering_policy=gathering_policy)
    Exception occured while running the command
    Traceback (most recent call last):
      File "/usr/lib/python3.6/site-packages/tripleoclient/command.py", line 32, in run
        super(Command, self).run(parsed_args)
      File "/usr/lib/python3.6/site-packages/osc_lib/command/command.py", line 41, in run
        return super(Command, self).run(parsed_args)
      File "/usr/lib/python3.6/site-packages/cliff/command.py", line 185, in run
        return_code = self.take_action(parsed_args) or 0
      File "/usr/lib/python3.6/site-packages/tripleoclient/v1/tripleo_validator.py", line 613, in take_action
        self._run_validator_run(parsed_args)
      File "/usr/lib/python3.6/site-packages/tripleoclient/v1/tripleo_validator.py", line 546, in _run_validator_run
        contents = json.load(val)
      File "/usr/lib64/python3.6/json/__init__.py", line 299, in load
        parse_constant=parse_constant, object_pairs_hook=object_pairs_hook, **kw)
      File "/usr/lib64/python3.6/json/__init__.py", line 354, in loads
        return _default_decoder.decode(s)
      File "/usr/lib64/python3.6/json/decoder.py", line 339, in decode
        obj, end = self.raw_decode(s, idx=_w(s, 0).end())
      File "/usr/lib64/python3.6/json/decoder.py", line 357, in raw_decode
        raise JSONDecodeError("Expecting value", s, err.value) from None
    json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
    Expecting value: line 1 column 1 (char 0)
    sys:1: ResourceWarning: unclosed <ssl.SSLSocket fd=4, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=6, laddr=('192.168.24.2', 56978), raddr=('192.168.24.2', 13000)>
    (undercloud) [stack@undercloud-0 ~]$

Comment 19 errata-xmlrpc 2020-07-29 07:52:55 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:3148