Bug 1836956

Summary: co-fetch should allow suppressing 404 errors
Product: OpenShift Container Platform Reporter: Filip Krepinsky <fkrepins>
Component: Management ConsoleAssignee: Jon Jackson <jonjacks>
Status: CLOSED NOTABUG QA Contact: Yadan Pei <yapei>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 4.5CC: aos-bugs, jokerman, pweil, spadgett, yzamir
Target Milestone: ---   
Target Release: 4.6.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-06-03 14:42:12 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Filip Krepinsky 2020-05-18 14:41:26 UTC 
Description of problem:
There are unnecessary console.error logs for resources which were not found (404). Even though, they are expected not to be found (for example with optional FirehoseResource property).

How reproducible:
100


Steps to Reproduce:
Please see https://bugzilla.redhat.com/show_bug.cgi?id=1821259, which is fixed by a hack (fetching the whole list).


Expected results:
It is possible to fetch standalone resource and specify suppression of 404 errors
Comment 2 Samuel Padgett 2020-06-03 14:42:12 UTC 
This is working as intended. The console messages are harmless and not displayed to the user. These are only for developers. It would be worse not to log the 404 response.
Comment 3 Samuel Padgett 2020-06-03 15:15:34 UTC 
The calling code should handle the failed promise if it's not.
Comment 4 Filip Krepinsky 2020-06-04 17:39:35 UTC 
In our case that is not possible, because we are using Firehose which calls watchK8sObject (k8sGet), which does not have any option of handling this.

This feature could be then added to firehose, if we don't want to modify the co-fetch.
Comment 5 Samuel Padgett 2020-06-04 18:15:39 UTC 
Sorry, I disagree with the premise. The 404 network requests are accurate and helpful for debugging. They aren't displayed to the user. We shouldn't misuse the k8s fieldSelector to suppress the message.
Comment 6 Filip Krepinsky 2020-06-04 18:37:58 UTC 
In general, I agree that it is helpful to have such logs. Nevertheless, VMI case is special, because we expect that it might not be there - VM page behaves differently according to that.

This feature would just help to cleanup the log a bit.