Bug 1837226

Summary: [manila-csi-driver-operator] manilacsi instance should only be allowed to be created once in a cluster
Product: OpenShift Container Platform Reporter: Wei Duan <wduan>
Component: StorageAssignee: Mike Fedosin <mfedosin>
Status: CLOSED ERRATA QA Contact: Wei Duan <wduan>
Severity: medium Docs Contact:
Priority: medium    
Version: 4.5CC: aos-bugs, egarcia, jsafrane
Target Milestone: ---   
Target Release: 4.5.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-07-13 17:39:55 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1832661    
Bug Blocks:    

Description Wei Duan 2020-05-19 06:32:41 UTC
Description of problem:
manilacsi instance should only be allowed to be created once in a cluster 

Version-Release number of selected component (if applicable):
4.5.0-0.nightly-2020-05-17-235851

How reproducible:
Always

Steps to Reproduce:
1. Login into the webconsole

2. Install csi-driver-manila-operator from operator hub with AllNamespaced method

3. Access the webpage: Operators->Installed Operators->csi-driver-manila-operator, Create manilacsi with name example-manilacsi-1 in manila-csi namespace, manila csi driver is installed successfully.

4. Create manilacsi with name example-manilacsi in namespace manila-csi-1, no new manila csi driver is installed.


Actual results:
manilacsi instance example-manilacsi is create successfully and no manila csi driver is installed. Get the logs:
{"level":"error","ts":1589866771.1004674,"logger":"controller-runtime.controller","msg":"Reconciler error","controller":"manilacsi-controller","request":"manila-csi-1/example-manilacsi","error":"cross-namespace owner references are disallowed, owner's namespace manila-csi-1, obj's namespace manila-csi","stacktrace":"github.com/go-logr/zapr.(*zapLogger).Error\n\t/go/src/github.com/openshift/csi-driver-manila-operator/vendor/github.com/go-logr/zapr/zapr.go:128\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/src/github.com/openshift/csi-driver-manila-operator/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:258\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/src/github.com/openshift/csi-driver-manila-operator/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:232\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).worker\n\t/go/src/github.com/openshift/csi-driver-manila-operator/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:211\nk8s.io/apimachinery/pkg/util/wait.JitterUntil.func1\n\t/go/src/github.com/openshift/csi-driver-manila-operator/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:152\nk8s.io/apimachinery/pkg/util/wait.JitterUntil\n\t/go/src/github.com/openshift/csi-driver-manila-operator/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:153\nk8s.io/apimachinery/pkg/util/wait.Until\n\t/go/src/github.com/openshift/csi-driver-manila-operator/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:88"}


Expected results:
Looks we only support manila csi driver is installed manila-csi namespace, so  manilacsi instance should only be allowed to be created once in a cluster, if there are other manilacsi instances are craeted, we should report clear msg.

Master Log:

Node Log (of failed PODs):

PV Dump:

PVC Dump:

StorageClass Dump (if StorageClass used by PV/PVC):

Additional info:

Comment 3 Wei Duan 2020-06-15 08:53:01 UTC
Verify fail.

[wduan@MINT appregistry]$ oc get maniladriver
NAME        AGE
cluster     80m
cluster-1   11s

Comment 5 Wei Duan 2020-06-17 13:12:13 UTC
Verified pass with image in https://errata.devel.redhat.com/advisory/54130

[wduan@MINT manila]$ oc get clusterversion
NAME      VERSION                             AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.5.0-0.nightly-2020-06-16-045437   True        False         10h     Cluster version is 4.5.0-0.nightly-2020-06-16-045437

[wduan@MINT appregistry]$ oc create -f 04_maniladriver.yaml
Error from server (AlreadyExists): error when creating "04_maniladriver.yaml": maniladrivers.csi.openshift.io "cluster" already exists
[wduan@MINT appregistry]$ vi 04_maniladriver.yaml
[wduan@MINT appregistry]$ oc create -f 04_maniladriver.yaml
The ManilaDriver "cluster-1" is invalid: metadata.name: Unsupported value: "cluster-1": supported values: "cluster"


The same message shows up in web console.

Comment 6 errata-xmlrpc 2020-07-13 17:39:55 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2409