Bug 1837640
Summary: | gfs2_jadd doesn't clean up if it runs out of space | ||
---|---|---|---|
Product: | Red Hat Enterprise Linux 7 | Reporter: | Abhijith Das <adas> |
Component: | gfs2-utils | Assignee: | Abhijith Das <adas> |
Status: | CLOSED ERRATA | QA Contact: | cluster-qe <cluster-qe> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 7.9 | CC: | adas, cluster-maint, cluster-qe, gfs2-maint, nstraz, pvlasin, rhandlin, swhiteho |
Target Milestone: | rc | ||
Target Release: | 7.9 | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | gfs2-utils-3.1.10-11.el7 | Doc Type: | If docs needed, set a value |
Doc Text: | Story Points: | --- | |
Clone Of: | 1833141 | Environment: | |
Last Closed: | 2020-09-29 20:33:28 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 1833141 | ||
Bug Blocks: | 1834456 |
Description
Abhijith Das
2020-05-19 18:04:55 UTC
When gfs2_jadd is run on an fs that's low on disk space, it could fail and leave the filesystem in an inconsistent state after having only partially done its job. The meta filesystem may remain mounted as well. The resulting inconsistent fs will not mount and fsck.gfs2 would be unable to fix this filesystem. gfs2_jadd is used rarely and the odds of someone running it with an almost-full fs is even lower. We even recommend that the fs be backed up before attempting gfs2_jadd. However, the failure renders the fs unusable, so the impact is severe. Requesting blocker+ for this bug. We have a fix for this upstream and in RHEL8 You shouldn't need blocker to get this in yet. Unless this is important enough that we need to make it a blocker anyway? Cancelling needinfo as this was not deemed a blocker. BEFORE - gfs2-utils-3.1.10-10.el7.x86_64 SCENARIO - [jadd_no_space] Creating 1G LV jadded on host-027 WARNING: gfs2 signature detected on /dev/fsck/jadded at offset 65536. Wipe it? [y/n]: [n] Aborted wiping of gfs2. 1 existing signature left on the device. Creating file system on /dev/fsck/jadded with options '-p lock_nolock -j 1 -J 128' on host-027 It appears to contain an existing filesystem (gfs2) /dev/fsck/jadded is a symbolic link to /dev/dm-2 This will destroy any data on /dev/dm-2 Discarding device contents (may take a while on large devices): Done Adding journals: Done Building resource groups: Done Creating quota file: Done Writing superblock and syncing: Done Device: /dev/fsck/jadded Block size: 4096 Device size: 1.00 GB (262144 blocks) Filesystem size: 1.00 GB (262142 blocks) Journals: 1 Journal size: 128MB Resource groups: 5 Locking protocol: "lock_nolock" Lock table: "" UUID: e6aeee2d-5721-4fd1-acff-e76c319167ce Mounting gfs2 /dev/fsck/jadded on host-027 with opts '' Filling some space Try to add more journals than there is space add_j: No space left on device Unexpected gfs2meta mounted after gfs2_jadd [root@host-025 sts-rhel7.9]# echo $? 1 AFTER - gfs2-utils-3.1.10-11.el7.x86_64 SCENARIO - [jadd_no_space] Creating 1G LV jadded on host-027 WARNING: gfs2 signature detected on /dev/fsck/jadded at offset 65536. Wipe it? [y/n]: [n] Aborted wiping of gfs2. 1 existing signature left on the device. Creating file system on /dev/fsck/jadded with options '-p lock_nolock -j 1 -J 128' on host-027 It appears to contain an existing filesystem (gfs2) /dev/fsck/jadded is a symbolic link to /dev/dm-2 This will destroy any data on /dev/dm-2 Discarding device contents (may take a while on large devices): Done Adding journals: Done Building resource groups: Done Creating quota file: Done Writing superblock and syncing: Done Device: /dev/fsck/jadded Block size: 4096 Device size: 1.00 GB (262144 blocks) Filesystem size: 1.00 GB (262142 blocks) Journals: 1 Journal size: 128MB Resource groups: 5 Locking protocol: "lock_nolock" Lock table: "" UUID: 8daf9acf-5cac-4d75-b5cb-1f5cbd1b470b Mounting gfs2 /dev/fsck/jadded on host-027 with opts '' Filling some space Try to add more journals than there is space Failed to add journals: No space left on device Insufficient space on the device to add 5 128MB journals (1MB QC size) Required space : 165465 blks (33093 blks per journal) Available space : 100745 blks Good, no gfs2meta mounts found Unmounting /mnt/fsck on host-027 Removing LV jadded on host-027 [root@host-025 sts-rhel7.9]# echo $? 0 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (gfs2-utils bug fix and enhancement update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2020:4008 |