Bug 1837652
| Summary: | [sig-builds][Feature:Builds] forcePull should affect pulling builder images ForcePull test case execution s2i | ||
|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | Petr Muller <pmuller> |
| Component: | Build | Assignee: | Gabe Montero <gmontero> |
| Status: | CLOSED ERRATA | QA Contact: | wewang <wewang> |
| Severity: | low | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 4.5 | CC: | adam.kaplan, aos-bugs, bparees, nalin, wzheng |
| Target Milestone: | --- | Flags: | adam.kaplan:
needinfo-
|
| Target Release: | 4.5.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | No Doc Update | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: |
[sig-builds][Feature:Builds] forcePull should affect pulling builder images ForcePull test case execution s2i
|
|
| Last Closed: | 2020-07-13 17:40:02 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Petr Muller
2020-05-19 18:26:19 UTC
This was caused by registry.redhat.io issues. It should be ok now, but it would be good to use this bug to confirm the test is passing again in recent runs. Based on the serach.svc query no imagestream related problems have occurred since 2 days ago when the TBR problems abated. So Ben's ask in #Comment 1 I believe is addressed. That said, these forcepull tests have been skipped for quite a while, re: https://github.com/openshift/origin/blob/master/test/extended/builds/forcepull.go#L112-L134 @Adam @Ben do we think the buildah based caching stuff will re-introduced the advantages of forcePull being set to true? Or is it time to just delete these tests. > @Adam @Ben do we think the buildah based caching stuff will re-introduced the advantages of forcePull being set to true?
Or is it time to just delete these tests.
i think it will reintroduce the value... my expectation is that if the "tag" exists in the local image cache, no registry check/pull will be performed, which would mean you get potentially stale content unless you do a forcepull.
But it might be worth confirming what the behavior will be with the buildah folks. They may only be caching layers by sha in which case the registry would always be consulted to get the latest shas for the tag, prior to cheecking the local cache for those shas, in which case there is no value in explicitly saying "force pull"
(In reply to Ben Parees from comment #3) > > @Adam @Ben do we think the buildah based caching stuff will re-introduced the advantages of forcePull being set to true? > Or is it time to just delete these tests. > > i think it will reintroduce the value... my expectation is that if the "tag" > exists in the local image cache, no registry check/pull will be performed, > which would mean you get potentially stale content unless you do a forcepull. > > But it might be worth confirming what the behavior will be with the buildah > folks. They may only be caching layers by sha in which case the registry > would always be consulted to get the latest shas for the tag, prior to > cheecking the local cache for those shas, in which case there is no value in > explicitly saying "force pull" Good point re: Buildah details @Nalin - do you have enough context here in this BZ address whether the current trend wrt buildah caches will be able to provide value for an openshift build's controls around always pulling its builder image? If not, perhaps we can discuss in the next devex scrum. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2020:2409 |