Bug 1838033

Summary:	Review Request: jakarta-activation - Jakarta Activation Specification and Implementation
Product:	[Fedora] Fedora	Reporter:	Fabio Valentini <decathorpe>
Component:	Package Review	Assignee:	Zbigniew Jędrzejewski-Szmek <zbyszek>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, zbyszek
Target Milestone:	---	Flags:	zbyszek: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-05-20 17:33:19 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1837685

Description Fabio Valentini 2020-05-20 11:52:09 UTC

Spec URL: https://decathorpe.fedorapeople.org/packages/jakarta-activation.spec
SRPM URL: https://decathorpe.fedorapeople.org/packages/jakarta-activation-1.2.1-5.fc32.src.rpm

Description:
Jakarta Activation lets you take advantage of standard services to:
determine the type of an arbitrary piece of data; encapsulate access to
it; discover the operations available on it; and instantiate the
appropriate bean to perform the operation(s).

Fedora Account System Username: decathorpe

koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=44727016

Note 1: Version 1.2.2 is available upstream, but it requires Java 9+.

Note 2: This package has previously been packaged as "jaf", but was retired (even if the retirement was botched, e.g. retirement commit merged back to stable branches ...)

The last build of "jaf" that is available on fedora 30-32 is jaf-1.2.1-4.fc30, which is why this new package will "Obsoletes: jaf < 1.2.1-5".

See: https://koji.fedoraproject.org/koji/buildinfo?buildID=1189610

Comment 1 Zbigniew Jędrzejewski-Szmek 2020-05-20 15:16:57 UTC

We have https://fedoraproject.org/wiki/Changes/Java11, so 1.2.2 could be packaged.
But I assume that you want this for F32 too, so holding back seems appropriate.
Once the new java is the default, the update should be pushed to rawhide.

Original review: #1649574

+ package name is OK (I guess, it seems better than jaf)
+ license is OK: BSD
+ builds and installs OK
+ BR: maven-local is present
+ BR/P/R look OK
+ P/O look OK
+ latest version (see the discussion above)
+ rpmlint and fedora-review are happy

Package is RE-APPROVED.

Comment 2 Fabio Valentini 2020-05-20 15:27:44 UTC

Thanks for the review!

Two comments for posterity:

Yes, I plan to update to the latest version once we have Java 11 by default. This package is still available on f32 due to the botched retirement, so I don't really need to push it there as well ... but since jaf failed to build since fedora 31, I could just push it in f31 and f32 too. /shrug

In both the upstream git repo and the official website, the project is referred to as "Jakarta Activation", and on the website they write that the project was previously named JAF (JavaBean Activation Framework), which is why I went with jakarta-activation.

Comment 3 Gwyn Ciesla 2020-05-20 15:45:55 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/jakarta-activation

Comment 4 Fabio Valentini 2020-05-20 17:33:19 UTC

Built for rawhide:
https://koji.fedoraproject.org/koji/buildinfo?buildID=1509081

Submitted to F32 and F31 to replace the botch-retired jaf:
https://bodhi.fedoraproject.org/updates/FEDORA-2020-bae32b4167
https://bodhi.fedoraproject.org/updates/FEDORA-2020-078132ba99