Bug 1838438

Summary: python-PyMuPDF fails to build: error: too many arguments to function ‘pdf_choice_widget_options’
Product: [Fedora] Fedora Reporter: Miro Hrončok <mhroncok>
Component: python-PyMuPDFAssignee: Scott Talbert <swt>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: cstratak, mhroncok, mplch, swt
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-05-21 16:28:19 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1785415, 1803234    

Description Miro Hrončok 2020-05-21 07:27:09 UTC
python-PyMuPDF fails to build with Python 3.9.0b1.

In file included from /usr/include/mupdf/pdf.h:23,
                 from fitz/fitz_wrap.c:2734:
/usr/include/mupdf/pdf/form.h:58:68: note: expected ‘int’ but argument is of type ‘pdf_widget *’ {aka ‘struct pdf_annot *’}
   58 | int pdf_choice_widget_options(fz_context *ctx, pdf_widget *tw, int exportval, const char *opts[]);
      |                                                                ~~~~^~~~~~~~~
fitz/fitz_wrap.c:6355:13: error: too many arguments to function ‘pdf_choice_widget_options’
 6355 |     int n = pdf_choice_widget_options(ctx, pdf, (pdf_widget *) annot, 0, NULL);
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.9/fedora-rawhide-x86_64/01396422-python-PyMuPDF/

For all our attempts to build python-PyMuPDF with Python 3.9, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/package/python-PyMuPDF/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.9:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Let us know here if you have any questions.

Python 3.9 will be included in Fedora 33. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.9.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Scott Talbert 2020-05-21 13:01:52 UTC
I don't think it's actually due to Python 3.9 - it's because mupdf got upgraded in Rawhide.  I got a notification from Koschei that it FTBFS in Rawhide currently.  I'll fix later today.

Comment 2 Miro Hrončok 2020-05-21 16:35:35 UTC
Thanks for the superfast response, Scott. You rock.

Comment 3 Scott Talbert 2020-05-21 16:42:22 UTC
Thankfully the upstream update was trivial (and the mupdf maintainer sent a PR).

Thanks for all of your work, too!  :-)