Bug 1838448

Summary: python-libpysal fails to build with Python 3.9: libpysal.io.iohandlers.tests.test_mat.test_MatIO fails
Product: [Fedora] Fedora Reporter: Miro Hrončok <mhroncok>
Component: python-libpysalAssignee: Elliott Sales de Andrade <quantum.analyst>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: cstratak, igor.raits, mhroncok, mplch, python-sig, quantum.analyst, thrnciar
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: python-libpysal-4.3.0-1.fc33 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-07-02 20:58:20 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1841712, 1842213    
Bug Blocks: 1785415, 1803234, 1803235, 1841732    

Description Miro Hrončok 2020-05-21 07:58:08 UTC
python-libpysal fails to build with Python 3.9.0b1.

FAIL: test_write (libpysal.io.iohandlers.tests.test_mat.test_MatIO)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/libpysal-4.2.2/libpysal/io/iohandlers/tests/test_mat.py", line 43, in test_write
    assert issubclass(warn[0].category, FutureWarning)
AssertionError: 
-------------------- >> begin captured stdout << ---------------------
 is not a file in any installed dataset.

--------------------- >> end captured stdout << ----------------------

----------------------------------------------------------------------
Ran 488 tests in 22.840s

FAILED (failures=1, skipped=41)

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.9/fedora-rawhide-x86_64/01397255-python-libpysal/

For all our attempts to build python-libpysal with Python 3.9, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/package/python-libpysal/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.9:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Let us know here if you have any questions.

Python 3.9 will be included in Fedora 33. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.9.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Miro Hrončok 2020-05-25 13:02:40 UTC
This comment is mass posted to all bugs blocking the Python 3.9 tracker, sorry if it is not 100 % relevant. When in doubt, please ask.


The Python 3.9 rebuild is in progress in a Koji side tag.

If you fix this bug, please don't rebuild the package in regular rawhide, but do it in the side tag with:

    $ fedpkg build --target=f33-python

The rebuild is progressing slowly and it is possible this package won't have all the required build dependencies yet. If that's the case, please just leave the fix committed and pushed and we will eventually rebuild it for you.

You are not asked to go and try rebuild all the missing dependencies yourself. If you know there is a bootstrap loop in the dependencies, let me know and we can untangle it together.

If you want to test your fix or reproduce the failure, you can still use the Copr repo mentioned in the initial comment of this bug: https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Comment 2 Miro Hrončok 2020-05-29 07:12:19 UTC
Python 3.9 update: The f33-python side tag is currently being merged.

New builds in f33-python are no longer possible, but python3 is not yet updated to Python 3.9 in rawhide. You can check when Python is Python 3.9 with:

    $ koji wait-repo f33-build --build python3.9-3.9.0~b1-3.fc3

And build the packages normally after that.

Comment 3 Tomáš Hrnčiar 2020-06-11 08:37:37 UTC
*** Bug 1841728 has been marked as a duplicate of this bug. ***

Comment 4 Tomáš Hrnčiar 2020-06-11 08:39:14 UTC
DEBUG util.py:600:  Error: 
DEBUG util.py:600:   Problem: conflicting requests
DEBUG util.py:600:    - nothing provides python3.8dist(pandas) >= 0.23 needed by python3-geopandas-0.7.0-1.fc33.noarch

Comment 5 Miro Hrončok 2020-06-17 11:01:09 UTC
Current problem:

======================================================================
FAIL: test_voronoi (libpysal.cg.tests.test_voronoi.Voronoi)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/libpysal-4.2.2/libpysal/cg/tests/test_voronoi.py", line 20, in test_voronoi
    self.assertTrue(vertices.tolist() == self.vertices)
AssertionError: False is not true
======================================================================
FAIL: test_write (libpysal.io.iohandlers.tests.test_mat.test_MatIO)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/libpysal-4.2.2/libpysal/io/iohandlers/tests/test_mat.py", line 43, in test_write
    assert issubclass(warn[0].category, FutureWarning)
AssertionError: 
-------------------- >> begin captured stdout << ---------------------
 is not a file in any installed dataset.
--------------------- >> end captured stdout << ----------------------
----------------------------------------------------------------------
Ran 488 tests in 35.287s
FAILED (failures=2, skipped=41)

Comment 6 Igor Raits 2020-06-18 12:54:51 UTC
Hello,

This is the first reminder (step 3 from https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs).

If you know about this problem and are planning on fixing it, please acknowledge so by setting the bug status to ASSIGNED. If you don't have time to maintain this package, consider orphaning it, so maintainers of dependent packages realize the problem.