Bug 1838926

Summary:	ovirt-node-ng-image CI broken due to c, network is not active
Product:	[oVirt] ovirt-node	Reporter:	Nir Levy <nlevy>
Component:	Build	Assignee:	Nir Levy <nlevy>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Sandro Bonazzola <sbonazzo>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	master	CC:	bugs, cshao, dfediuck, lsvaty, mavital, nlevy, peyu, qiyuan, sbonazzo, weiwang, yaniwang
Target Milestone:	ovirt-4.4.1	Keywords:	AutomationBlocker, CodeChange
Target Release:	4.4.0	Flags:	sbonazzo: ovirt-4.4? sbonazzo: planning_ack? sbonazzo: devel_ack+ cshao: testing_ack+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	ovirt-node-ng-image-4.4.1_rc4	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-06-03 16:05:14 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Node	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Nir Levy 2020-05-22 05:00:16 UTC

Description of problem:
During CI Checkpatch ISO generation is broken due to cho "ISO install failed, exiting" 

Version-Release number of selected component (if applicable):
4.4.1

How reproducible:
100%

Steps to Reproduce:
1. when pushing patch to CI, CI failed
2. check_iso stage failed to receive ISO addr
   setup-iso.log reviles
   "ERROR    Requested operation is not valid: network 'ovirt-node-net' is not active"
3. as a result setup_rc returns 1 and script exit
   echo "ISO install failed, exiting" is not reported

Actual results:
   check-patch CI failed

Expected results:
   chech-patch check ISO succeed.


Additional info:

Comment 1 Nir Levy 2020-05-22 10:14:14 UTC

prepare_network function returns when network is defined and not
verify it to be active.