Bug 1838992
| Summary: | %pycached cannot be used with %exclude | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Miro Hrončok <mhroncok> |
| Component: | python-rpm-macros | Assignee: | Miro Hrončok <mhroncok> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | low | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | cstratak, j, m.cyprian, mhroncok, orion, pviktori, python-sig |
| Target Milestone: | --- | Keywords: | FutureFeature, Reopened |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | python-rpm-macros-3.9-3.fc33 python-rpm-macros-3-58.fc32 python-rpm-macros-3-57.fc31 | Doc Type: | Enhancement |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-10-13 09:45:05 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
The "reasonable fix" is to replace:
path = rpm.expand("%{?1}")
with:
path = rpm.expand("%{?*}")
In %pycached definition. Whoever gets to that, please take it.
I have submitted a pull request here: https://src.fedoraproject.org/rpms/python-rpm-macros/pull-request/62 This is now fixed in rawhide. Leaving in POST because backports are necessary and the guidelines still need the note. FEDORA-EPEL-2020-8ae5e07128 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-8ae5e07128 FEDORA-2020-ac08d74be3 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-ac08d74be3 FEDORA-EPEL-2020-8ae5e07128 has been pushed to the Fedora EPEL 7 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-8ae5e07128 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2020-4411a39579 has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-4411a39579` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-4411a39579 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2020-ac08d74be3 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-ac08d74be3` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-ac08d74be3 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2020-ac08d74be3 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2020-4411a39579 has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-EPEL-2020-8ae5e07128 has been pushed to the Fedora EPEL 7 stable repository. If problem still persists, please make note of it in this bug report. Leaving in ON_QA because the guidelines still need the note. |
The following naïve code: %exclude %pycached %{python3_sitelib}/%{name}/steps/provision/podman.py Generates: %exclude /usr/lib/python3.8/site-packages/%{name}/steps/provision/podman.py /usr/lib/python3.8/site-packages/%{name}/steps/provision/__pycache__/podman.cpython-38{,.opt-?}.pyc Which is kinda bad and dangerous. -------- The following naïve code: %pycached %exclude %{python3_sitelib}/%{name}/steps/provision/podman.py Errors: %pycached can only be used with paths explicitly ending with .py Which is kinda not the correct error line. --------- AFAIK the first case is CANTFIX, but the second one can be reasonably fixed to produce: %exclude /usr/lib/python3.8/site-packages/%{name}/steps/provision/podman.py %exclude /usr/lib/python3.8/site-packages/%{name}/steps/provision/__pycache__/podman.cpython-38{,.opt-?}.pyc If it is, we can document that users need to use "%pycached %exclude" instead of "%exclude %pycached" in the guidelines, as a caveat.