Bug 1839052
| Summary: | Review Request: plasma-wayland-protocols - Plasma Specific Protocols for Wayland | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Martin Kyral <mkyral> |
| Component: | Package Review | Assignee: | Jan Grulich <jgrulich> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jgrulich, package-review, ppisar, rdieter |
| Target Milestone: | --- | Flags: | jgrulich:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | plasma-wayland-protocols-1.0-1.fc33 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-02-23 15:26:22 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Martin Kyral
2020-05-22 12:04:48 UTC
1) License should be LGPLv2+ and MIT and BSD 2) It doesn't need qt5-qtbase-devel, because it contains only xml files 3) I also think that the commented part about bootstrap and tests can be removed, together with -DBUILD_TESTING cmake option > 2) It doesn't need qt5-qtbase-devel, because it contains only xml files
actually, it does:
CMake Error at /usr/share/ECM/modules/ECMQueryQmake.cmake:30 (message):
No qmake Qt5 binary found. Can't check QT_INSTALL_PLUGINS as required
Call Stack (most recent call first):
/usr/share/ECM/kde-modules/KDEInstallDirs.cmake:489 (query_qmake)
CMakeLists.txt:13 (include)
1) and 3) fixed 2) turns out that qt5-qtbase-devel indeed is a BuildRequire SPEC: https://download.copr.fedorainfracloud.org/results/mkyral/plasma-unstable/fedora-rawhide-x86_64/01402981-plasma-wayland-protocols/plasma-wayland-protocols.spec SRPM: https://download.copr.fedorainfracloud.org/results/mkyral/plasma-unstable/fedora-rawhide-x86_64/01402981-plasma-wayland-protocols/plasma-wayland-protocols-1.0-1.fc33.src.rpm 1) License ok 2) Naming ok 3) Scriptlets ok - not needed 4) Rpmlint ok Looks good now. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/plasma-wayland-protocols Build succesfull: https://koji.fedoraproject.org/koji/taskinfo?taskID=44991692 closing, imported long ago |