Bug 1839111

Summary: [RFE] Need better error code for checkpoint functions
Product: Red Hat Enterprise Linux 8 Reporter: Gris Ge <fge>
Component: NetworkManagerAssignee: NetworkManager Development Team <nm-team>
Status: CLOSED DEFERRED QA Contact: Vladimir Benes <vbenes>
Severity: low Docs Contact:
Priority: low    
Version: ---CC: acardace, atragler, bgalvani, bsanford, lrintel, pasik, rkhan, sukulkar, thaller, till, vbenes
Target Milestone: rcKeywords: FutureFeature, Triaged
Target Release: 8.5Flags: pm-rhel: mirror+
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-09-18 06:07:40 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1738136    

Description Gris Ge 2020-05-22 13:59:13 UTC 
Description of problem:

Currently, libnm is using `NM.ManagerError` for checkpoint creation/deletion/rollback failures.

And `NM.ManagerError.INVALIDARGUMENTS` is used for:

 * Conflicting checkpoint.
 * Checkpoint not exists.

Version-Release number of selected component (if applicable):

NetworkManager-1.25.1-25861.7b9cb1f952.el8.x86_64

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Please create new error class or new error code for these cases:
 * Checkpoint dbus path not exists.
 * Creation failure due to conflict.
 * Creation failure due to permission error. Current is NM.ManagerError.PERMISSIONDENIED
Comment 6 Gris Ge 2021-09-18 06:07:40 UTC 
Closing due to out of capacity for this decorative issue.
Will reopn when does.