Bug 1839503

Summary: Review Request: golang-github-valyala-fasthttp - Fast HTTP package
Product: [Fedora] Fedora Reporter: Fabian Affolter <mail>
Component: Package ReviewAssignee: Robert-André Mauchin 🐧 <eclipseo>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: eclipseo, package-review
Target Milestone: ---Flags: eclipseo: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-07-19 01:09:03 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1839500    
Bug Blocks:    

Description Fabian Affolter 2020-05-24 12:52:54 UTC
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-valyala-fasthttp.spec
SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-valyala-fasthttp-0.1.0-1.fc31.src.rpm

Project URL: https://github.com/valyala/fasthttp

Description:
Fast HTTP package for Go. Tuned for high performance. Zero memory allocations
in hot paths. Up to 10x faster than net/http.

Koji scratch build:
missing dependency

rpmlint output:
$ rpmlint golang-github-valyala-fasthttp-0.1.0-1.fc31.src.rpm 
golang-github-valyala-fasthttp.src: W: no-%build-section
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

$ rpmlint golang-github-valyala-fasthttp-devel-0.1.0-1.fc31.noarch.rpm 
golang-github-valyala-fasthttp-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/valyala/fasthttp/.goipath
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

Fedora Account System Username: fab

Comment 1 Robert-André Mauchin 🐧 2020-06-26 09:50:13 UTC
0.1.0 is an old release: https://github.com/valyala/fasthttp/tags Latest tagged version is 1.14.0. Luckily all the new deps are already packaged:

BuildRequires:  golang(github.com/andybalholm/brotli)
BuildRequires:  golang(github.com/klauspost/compress/flate)
BuildRequires:  golang(github.com/klauspost/compress/gzip)
BuildRequires:  golang(github.com/klauspost/compress/zlib)
BuildRequires:  golang(github.com/valyala/bytebufferpool)
BuildRequires:  golang(github.com/valyala/tcplisten)
BuildRequires:  golang(golang.org/x/net/proxy)

Comment 2 Fabian Affolter 2020-07-03 07:03:18 UTC
(In reply to Robert-André Mauchin 🐧 from comment #1)
> 0.1.0 is an old release: https://github.com/valyala/fasthttp/tags Latest
> tagged version is 1.14.0. Luckily all the new deps are already packaged:
> 
> BuildRequires:  golang(github.com/andybalholm/brotli)
> BuildRequires:  golang(github.com/klauspost/compress/flate)
> BuildRequires:  golang(github.com/klauspost/compress/gzip)
> BuildRequires:  golang(github.com/klauspost/compress/zlib)
> BuildRequires:  golang(github.com/valyala/bytebufferpool)
> BuildRequires:  golang(github.com/valyala/tcplisten)
> BuildRequires:  golang(golang.org/x/net/proxy)

Thanks for the feedback. Updated to 1.14.0

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=46499030


%changelog
* Tue Jun 30 2020 Fabian Affolter <mail> - 1.14.0-1
- Update to latest upstream release 1.14.0 (rhbz#1839503)

Spec URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-valyala-fasthttp.spec
SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-valyala-fasthttp-0.1.0-1.fc31.src.rpm

Comment 3 Robert-André Mauchin 🐧 2020-07-03 10:41:55 UTC
Package is approved.


Thanks so much for helping with my own reviews!

Comment 4 Gwyn Ciesla 2020-07-03 19:15:07 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-valyala-fasthttp

Comment 5 Fedora Update System 2020-07-10 08:29:54 UTC
FEDORA-2020-dad23b44a2 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-dad23b44a2

Comment 6 Fedora Update System 2020-07-10 08:44:31 UTC
FEDORA-2020-a2a9eb0cb8 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-a2a9eb0cb8

Comment 7 Fedora Update System 2020-07-11 01:36:23 UTC
FEDORA-2020-dad23b44a2 has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-dad23b44a2 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-dad23b44a2

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2020-07-11 02:06:13 UTC
FEDORA-2020-a2a9eb0cb8 has been pushed to the Fedora 31 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-a2a9eb0cb8 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-a2a9eb0cb8

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2020-07-19 01:09:03 UTC
FEDORA-2020-dad23b44a2 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 10 Fedora Update System 2020-07-19 02:19:24 UTC
FEDORA-2020-a2a9eb0cb8 has been pushed to the Fedora 31 stable repository.
If problem still persists, please make note of it in this bug report.