Bug 184026

Summary: fstab-sync breaks symlinked /etc/fstab
Product: [Fedora] Fedora Reporter: JW <ohtmvyyn>
Component: halAssignee: David Zeuthen <davidz>
Status: CLOSED CANTFIX QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: 6CC: mclasen
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-04-11 01:46:33 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
A lrename() function to use instead of rename() none

Description JW 2006-03-05 03:02:00 UTC 
Description of problem:
If /etc/fstab is a symlink then fstab-sync will replace it with a plain file
even if no changes need to be made (often the case).

Version-Release number of selected component (if applicable):
hal-0.5.2-2

How reproducible:
Always

Steps to Reproduce:
1.create /etc.fstab as a symlink
2.induce fstab-sync to run (rebooting is one way)
3.check what happened to symlink
  
Actual results:
symlink broken and replace by plain file

Expected results:
symlink retained and target modified


Additional info:
Comment 1 JW 2006-03-05 03:02:00 UTC 
Created attachment 125657 [details]
A lrename() function to use instead of rename()
Comment 2 JW 2006-03-05 03:05:02 UTC 
This is a lrename() function which differs from rename() in that it attempt to
follow a destination symbolic link.  It is as atomic as rename().  Using this
function instead of rename(P) will ensure that symbolic links are preserved if
possible, on the grounds that people create symbolic links intentionally and
they really want all file reading/writing to go to the symlink target and not
the symlink itself.

Symbolic links should be transparent as far as possible.
Comment 3 Christian Iseli 2007-01-22 10:22:30 UTC 
This report targets the FC3 or FC4 products, which have now been EOL'd.

Could you please check that it still applies to a current Fedora release, and
either update the target product or close it ?

Thanks.
Comment 4 JW 2007-01-22 11:00:31 UTC 
no info
Comment 5 Matthew Miller 2007-04-10 19:44:41 UTC 
Fedora Core 4 is now completely unmaintained. These bugs can't be fixed in that
version. If the issue still persists in current Fedora Core, please reopen.
Thank you, and sorry about this.
Comment 6 JW 2007-04-11 00:20:54 UTC 
Applicable to Fedora Core 6. Sorry about that.
Comment 7 David Zeuthen 2007-04-11 00:43:11 UTC 
CANTFIX as fstab-sync is not in FC6. Closing.
Comment 8 JW 2007-04-11 00:56:53 UTC 
The name has changed - it now occurs in
libexec/hal-storage-cleanup-all-mountpoints and
libexec/hal-storage-cleanup-mountpoint etc.  The same problem exists.
Comment 9 David Zeuthen 2007-04-11 01:46:33 UTC 
Uhm, no. These functions operate on /media/.hal-mtab
Comment 10 JW 2007-04-11 01:50:01 UTC 
Congratulations. You passed my alertness test. Thank you.