Bug 1840286

Summary:	[MIG-UI] Empty playbook hooks break the migration plan
Product:	OpenShift Container Platform	Reporter:	Erik Nelson <ernelson>
Component:	Migration Tooling	Assignee:	Erik Nelson <ernelson>
Status:	CLOSED ERRATA	QA Contact:	Xin jiang <xjiang>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	4.4	CC:	chezhang, ernelson, jmatthew, mberube, rjohnson, rpattath, sregidor, whu, xjiang
Target Milestone:	---
Target Release:	4.4.z
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1840226	Environment:
Last Closed:	2020-06-17 00:04:13 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1840226
Bug Blocks:

Description Erik Nelson 2020-05-26 17:01:17 UTC

+++ This bug was initially created as a clone of Bug #1840226 +++

Description of problem:
When we configure an empty playbook when we add a hook to a migration plan, the migration plan is left in a state where we cannot edit it in order to fix the empty playbook

Version-Release number of selected component (if applicable):
CAM 1.2 stage

How reproducible:
Always

Steps to Reproduce:
1. Create a migration plan
2. In hooks screen add a hook to the migration plan
3. Leave the field "Ansible playbook" empty. Do not introduce any playbook.

Actual results:
The migration plan is broken and in "Not Ready" status. When we try to edit the migration plan in order to fix the problem, the edit screen is broken before we can reach the hook that we need to edit.

Expected results:
Probably empty playbooks should not be allowed.

Additional info:

--- Additional comment from Erik Nelson on 2020-05-26 17:00:15 UTC ---

https://bugzilla.redhat.com/show_bug.cgi?id=1840226

Comment 1 Erik Nelson 2020-05-26 17:01:33 UTC

https://github.com/konveyor/mig-ui/pull/878

Comment 5 Sergio 2020-06-09 09:34:14 UTC

Verified using CAM 1.2.2 stage

    - name: MIG_UI_REPO
      value: openshift-migration-ui-rhel8@sha256
    - name: MIG_UI_TAG
      value: 6abfaea8ac04e3b5bbf9648a3479b420b4baec35201033471020c9cae1fe1e11


UI does not allow to create a hook with an empty playbook. It displays this warning "Ansible file upload required".

Comment 7 errata-xmlrpc 2020-06-17 00:04:13 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2020:2571