Bug 1840958

Summary:	The content of source can be empty on Wizard general step
Product:	OpenShift Container Platform	Reporter:	Guohua Ouyang <gouyang>
Component:	Console Kubevirt Plugin	Assignee:	Yaacov Zamir <yzamir>
Status:	CLOSED ERRATA	QA Contact:	Guohua Ouyang <gouyang>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	4.5	CC:	aos-bugs, fkrepins, gouyang, jintan, mcarleto, yzamir
Target Milestone:	---	Keywords:	Reopened, UsabilityStudyPriority
Target Release:	4.6.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-10-27 16:01:53 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Guohua Ouyang 2020-05-28 01:51:52 UTC

Description of problem:
The content of source can be empty on Wizard general step, it's a required field, it should not PASS if it's blank.

Version-Release number of selected component (if applicable):
master

How reproducible:
100%

Steps to Reproduce:
1. On wizard, select URL/Container
2. Don't fill URL/Container Image
3. Fill other fields and Click "Next"

Actual results:
It goes to Network step, and "URL cannot be empty" shows on Storage step.

Expected results:
It should error with "Required fields not completed".

Additional info:

Comment 1 Filip Krepinsky 2020-05-28 12:06:04 UTC

It is required, but it is validated in two places. You can change it in storage tab as well. 

So if you do not specify it you will be stopped in storage tab and required to fill it there.

IMO that is better behaviour as you can deffer the action and fill it in one place together with storage class/size/interface

Comment 2 Tomas Jelinek 2020-05-28 12:11:16 UTC

Based on Comment 1, closing as not a bug.

Comment 3 Guohua Ouyang 2020-05-28 12:27:01 UTC

It does not validate the field in general tab as it could process to next tab.
I can't agree this is a better behavior because it's marked "required" but validate in other place, it's an unusual design.

Comment 4 Tomas Jelinek 2020-05-28 12:29:07 UTC

alright, maybe I had a bit fast trigger :)
Reopening and targeting 4.6 so we can re-discuss the design.

Adding @Matt to the party

Comment 5 Tomas Jelinek 2020-05-29 08:22:30 UTC

It is not clear how to approach it, hence we did not fix it.

Comment 6 Yaacov Zamir 2020-07-08 12:22:34 UTC

re-set severity and priority to medium

AFAIU customers can have all the functionality without any disruption ( high severity say - "customer's operation is disrupted, but there is some capacity to produce." )

Comment 7 Tomas Jelinek 2020-07-10 06:57:30 UTC

We fixed some bugs last sprint, did not have capacity to fix this one. Setting upcoming sprint.

Comment 10 Yaacov Zamir 2020-08-11 07:43:46 UTC

We are removing the red asterisk (indicating required field) from the URL and Container Image fields so users will not think they must fill them in before clicking "Next"

Comment 12 Matt 2020-09-04 03:26:45 UTC

This should be resolved with the new wizard designs where we allow the user to address the source step more specifically in the OS step of the wizard. Would you agree Tomas

Comment 14 errata-xmlrpc 2020-10-27 16:01:53 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.6 GA Images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4196