Bug 1841292

Summary:	nftables manpage omits 'notrack' keyword
Product:	Red Hat Enterprise Linux 8	Reporter:	Tomas Dolezal <todoleza>
Component:	nftables	Assignee:	Phil Sutter <psutter>
Status:	CLOSED ERRATA	QA Contact:	Jiri Peska <jpeska>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	8.3	CC:	jpeska, psutter, todoleza
Target Milestone:	rc	Keywords:	Documentation
Target Release:	8.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	nftables-0.9.3-14.el8	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1850527 (view as bug list)		Environment:
Last Closed:	2020-11-04 01:58:24 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Tomas Dolezal 2020-05-28 19:09:37 UTC

Description of problem:
in iptables' raw table there's -j NOTRACK target which should translate into 'notrack' as described at nftables wiki [1]. current manpage uses this keyword only in examples without having it in correct section (around CT?).

[1] https://wiki.nftables.org/wiki-nftables/index.php/Setting_packet_connection_tracking_metainformation

Version-Release number of selected component (if applicable):
nftables-0.9.3-12.el8.x86_64

How reproducible:
always

Steps to Reproduce:
observe nft manpage

Actual results:
>tcp flags syn notrack
..is the only mention of this after "Make SYN packets untracked." example

Expected results:
possibly exhaustive list of all permitted keywords (with kernel version support information if needed) that would include "notrack"

Additional info:
iptables-translate also fails to translate this rule:
>iptables-translate -t raw -A PREROUTING -p tcp --dport 6801 -j NOTRACK
nft # -t raw -A PREROUTING -p tcp --dport 6801 -j NOTRACK

Comment 1 Phil Sutter 2020-06-22 13:26:59 UTC

Missing translation fixed upstream by commit:

commit f3d4a3ddbcfca15a00dd9758f481420038f6de10
Author: Pablo Neira Ayuso <pablo>
Date:   Wed Apr 15 18:16:41 2020 +0200

    extensions: libxt_CT: add translation for NOTRACK
    
    Signed-off-by: Pablo Neira Ayuso <pablo>


Missing man page entry fixed upstream as well:

commit f16fbe76f62dcb9f7395d1837ad2d056463ba55f
Author: Phil Sutter <phil>
Date:   Mon Jun 22 15:07:40 2020 +0200

    doc: Document notrack statement
    
    Merely a stub, but better to mention it explicitly instead of having it
    appear in synproxy examples and letting users guess as to what it does.
    
    Signed-off-by: Phil Sutter <phil>
    Reviewed-by: Florian Westphal <fw>

Comment 2 Tomas Dolezal 2020-06-23 17:43:05 UTC

Hello Phil,
(In reply to Phil Sutter from comment #1)
> Missing translation fixed upstream by commit:
> 
> commit f3d4a3ddbcfca15a00dd9758f481420038f6de10
> Author: Pablo Neira Ayuso <pablo>
> Date:   Wed Apr 15 18:16:41 2020 +0200
> 
>     extensions: libxt_CT: add translation for NOTRACK
>     
>     Signed-off-by: Pablo Neira Ayuso <pablo>

I saw this commit in iptables repo which is not related to nftables component AFAIK. Could you please check that it's the correct commit and bugzilla?

Comment 3 Phil Sutter 2020-06-24 09:41:06 UTC

Hi Tomas,

(In reply to Tomas Dolezal from comment #2)
> Hello Phil,
> (In reply to Phil Sutter from comment #1)
> > Missing translation fixed upstream by commit:
> > 
> > commit f3d4a3ddbcfca15a00dd9758f481420038f6de10
> > Author: Pablo Neira Ayuso <pablo>
> > Date:   Wed Apr 15 18:16:41 2020 +0200
> > 
> >     extensions: libxt_CT: add translation for NOTRACK
> >     
> >     Signed-off-by: Pablo Neira Ayuso <pablo>
> 
> I saw this commit in iptables repo which is not related to nftables
> component AFAIK. Could you please check that it's the correct commit and
> bugzilla?

Ah, sorry for the confusion. Indeed the two mentioned commits belong to
different repositories. I'll clone this ticket for iptables component to add
translation for NOTRACK target.

From a technical point of view we're talking features here. Would you agree? If so, I guess we should move the ticket(s) to 8.4.

Cheers, Phil

Comment 4 Tomas Dolezal 2020-06-24 16:18:20 UTC

Phil,
as this is just a documentation fix, I don't see a reason not to include it now.
The iptables "translation" bug 1850527 is indeed RFE, I also removed Documentation keyword there as it was not relevant at all.

Comment 10 errata-xmlrpc 2020-11-04 01:58:24 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (nftables bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2020:4535