Bug 1841336

Summary:	Review Request: rust-khronos_api - The Khronos XML API Registry, exposed as byte string constants
Product:	[Fedora] Fedora	Reporter:	Stefano Figura <stefano>
Component:	Package Review	Assignee:	Robert-André Mauchin 🐧 <zebob.m>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	michel, package-review, zebob.m
Target Milestone:	---	Flags:	zebob.m: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-06-29 20:26:09 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1839330
Bug Blocks:	1846000

Description Stefano Figura 2020-05-28 21:55:13 UTC

Spec URL: https://git.sr.ht/~returntrip/khronos_api/blob/master/rust-khronos_api.spec
SRPM URL: https://git.sr.ht/~returntrip/khronos_api/blob/master/rust-khronos_api-3.1.0-1.fc33.src.rpm
Koji Scratch Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=45115565
Description: The Khronos XML API Registry, exposed as byte string constants.
Fedora Account System Username: returntrip

Comment 1 Michel Lind 2020-06-14 21:56:42 UTC

Two files are identified as having the "Khronos license", and I just checked and they are in the generated -devel RPM.

Khronos License                                                
---------------                                                
khronos_api-3.1.0/api_angle/scripts/egl.xml                    
khronos_api-3.1.0/api_egl/api/egl.xml

The license reads like MIT to me, and when searching for occurences in Fedora I get this that also mark them as MIT, so maybe the declared license for the package should be "ASL 2.0 and MIT" with a comment listing these two files. 

https://fedorapeople.org/~airlied/opencl/opencl-headers.spec

Comment 2 Stefano Figura 2020-06-14 22:18:18 UTC

(In reply to Michel Alexandre Salim from comment #1)
> Two files are identified as having the "Khronos license", and I just checked
> and they are in the generated -devel RPM.
> 
> Khronos License                                                
> ---------------                                                
> khronos_api-3.1.0/api_angle/scripts/egl.xml                    
> khronos_api-3.1.0/api_egl/api/egl.xml
> 
> The license reads like MIT to me, and when searching for occurences in
> Fedora I get this that also mark them as MIT, so maybe the declared license
> for the package should be "ASL 2.0 and MIT" with a comment listing these two
> files. 
> 
> https://fedorapeople.org/~airlied/opencl/opencl-headers.spec

Thanks for catching this one, I have added the MIT license to the spec file and uploaded spec file and srpm.

Comment 3 Robert-André Mauchin 🐧 2020-06-29 17:56:59 UTC

Finishing this if you don't mind so I can use it to build the dependant packages.

 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved.

Comment 4 Stefano Figura 2020-06-29 19:11:20 UTC

Thanks for reviewing!

fedpkg request-repo rust-khronos_api 1841336
https://pagure.io/releng/fedora-scm-requests/issue/26649

Comment 5 Gwyn Ciesla 2020-06-29 19:53:27 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-khronos_api