Bug 1841556
Summary: | OCPRHV-104: SDK - go-ovirt: NICs not displaying correctly | ||
---|---|---|---|
Product: | Red Hat Enterprise Virtualization Manager | Reporter: | Douglas Schilling Landgraf <dougsland> |
Component: | distribution | Assignee: | Roberto Ciatti <rciatti> |
Status: | CLOSED UPSTREAM | QA Contact: | Lucie Leistnerova <lleistne> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 4.3.11 | CC: | abonilla, lsurette, mhicks, oliel, rbarry, rciatti, srevivo |
Target Milestone: | ovirt-4.3.11 | Keywords: | ZStream |
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2020-06-08 15:21:14 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | Integration | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1838559 |
Description
Douglas Schilling Landgraf
2020-05-29 13:06:58 UTC
Hi, working together with Douglas we discovered a problem in the 'go-ovirt' and probably at https://github.com/oVirt/go-ovirt/blob/master/readers.go#L14234 where the reader is gonna parse the name_server section of the XML coming from the ovirt engine REST api. Probably worth to look at the 'ovirt-engine-sdk-go' ReadersGenerator. Trying with another sdk (e.g.: the 'ovirt-engine-sdk-ruby') all the nics are reported correctly (using the code below) require 'ovirtsdk4' BASE_OPTS = { url: 'https://<engine-fqdn>/ovirt-engine/api', username: 'admin@internal', password: 'pass', timeout: 3600, insecure: true, connect_timeout: 60 }.freeze conn = OvirtSDK4::Connection.new(BASE_OPTS) sys_srv = conn.system_service cls_srv = sys_srv.clusters_service cls_srv.list.each do |c| puts "Cluster: #{c.name}, #{c.id}" cl_service = cls_srv.cluster_service(c.id) cl_net_srv = cl_service.networks_service nics = cl_net_srv.list puts nics.map(&:name) end The problem in the ovirt-go readers.go parser https://github.com/oVirt/go-ovirt/blob/9bcc4fd4e6c0921d07d328036c73abbea369e023/readers.go#L14202 parsing the sub tag 'dns_resolver_configuration' the is completely compromising the tag hierarchy. Need some modification to the ovirt-engine-sdk-go generator for this section Roberto is working in this bug, setting the Github WIP patch as attachment and setting owner. Proposed a solution to solve the problem and tests added to cover the case. All the other tests are passing too. Current patch is merged on master, do we need it backported to 4.3? or SDK 4.4 will be ok? The problem is also on the sdk 4.3. According to me, backporting the patch would allow clients that are using the 4.3 to work properly, but I'll leave the decision to the maintainer. IMHO I'd close this BZ as a consequence of the upstream merge. As the reporter for this bug, I am okay to close this bug as upstream merged and verified the patch (with Robert's testing patch as well). |