Bug 1842480

Summary: pcp-atop crashes dereferencing NULL pointer curstat
Product: Red Hat Enterprise Linux 7 Reporter: Divya <dbasant>
Component: pcpAssignee: pcp-maint <pcp-maint>
Status: CLOSED DUPLICATE QA Contact: qe-baseos-tools-bugs
Severity: high Docs Contact:
Priority: high    
Version: 7.7CC: agerstmayr, jkurik, mgoodwin, nathans, patrickm
Target Milestone: rcKeywords: Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-06-02 02:10:45 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Patch including a check for curstat being a valid pointer dbasant: review?

Comment 2 Divya 2020-06-01 11:30:20 UTC
Created attachment 1694073 [details]
Patch including a check for curstat being a valid pointer

Comment 3 Nathan Scott 2020-06-02 00:18:13 UTC
Hi Divya,

I think this is the same issue fixed by upstream commit c22151f463e3e2494850210444a69948dc0fbdd6 ... this was introduced as the very last change in 1818710 - is it possible the customer didn't have a build with that change?  I don't see an explicit mention of it in the BZ, but do recall this was added to the most recent RHEL 7.9 build and us discussing it on IRC.

That commit provides a less invasive fix than the attached patch I think.

cheers.

Comment 4 Divya 2020-06-02 02:02:08 UTC
I checked in the upstream code base and commit c22151f463e3e2494850210444a69948dc0fbdd6 went in on May 19th, whereas I did a test build for customer on May 18th, so yes this one was missed in the last build packages I provided to customer. Sorry about the confusion here. I'll initiate another build in sometime including the mentioned commit here and discard the fix I mentioned here as your fix is more inclusive and neat. 

IMHO, having the commit mentioned on the bz #1818710, will also be useful for future reference.

Comment 5 Nathan Scott 2020-06-02 02:10:45 UTC

*** This bug has been marked as a duplicate of bug 1818710 ***