Bug 1843417
| Summary: | Cannot compile code with nss headers and -Werror=strict-prototypes | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Lukas Slebodnik <lslebodn> |
| Component: | nss | Assignee: | Bob Relyea <rrelyea> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | crypto-team, dueno, elio.maldonado.batiz, kdudka, kengert, rrelyea |
| Target Milestone: | --- | Keywords: | Regression |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | nss-3.53.0-2.fc32 nss-3.53.0-2.fc31 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-06-16 01:30:16 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
FEDORA-2020-fc6d6ec06f has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-fc6d6ec06f FEDORA-2020-b677736a37 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-b677736a37 nss-3.53.0-2.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-b677736a37 nss-3.53.0-2.fc32 has been pushed to the Fedora 32 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-fc6d6ec06f nss-3.53.0-2.fc32 has been pushed to the Fedora 32 stable repository. If problems still persist, please make note of it in this bug report. FEDORA-2020-b677736a37 has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. |
Description of problem: The latest upgrade of nss broke compilation with -Werror=strict-prototypes Version-Release number of selected component (if applicable): How reproducible: Deterministic Steps to Reproduce: 1. dnf install -y gcc nss-devel 2. cat >test.c <<EOF #include <nss.h> #include <sechash.h> #include <pk11func.h> EOF 3. gcc `pkg-config --cflags nss` -c -Wstrict-prototypes -Werror=strict-prototypes test.c Actual results: sh-5.0$ gcc `pkg-config --cflags nss` -c -Wstrict-prototypes -Werror=strict-prototypes test.c In file included from /usr/include/nss3/pk11func.h:12, from test.c:3: /usr/include/nss3/pk11pub.h:951:1: error: function declaration isn’t a prototype [-Werror=strict-prototypes] 951 | int SECMOD_GetSystemFIPSEnabled(); | ^~~ cc1: some warnings being treated as errors sh-5.0$ echo $? 1 Expected results: sh-5.0$ gcc `pkg-config --cflags nss` -c -Wstrict-prototypes -Werror=strict-prototypes test.c sh-5.0$ echo $? 0 Additional info: Looks like it was newly added function. sh-5.0$ grep -RniI SECMOD_GetSystemFIPSEnabled /usr/include/ sh-5.0$ rpm -q nss-devel nss-devel-3.52.0-2.fc33.x86_64 And simple workaround is to run following command as root sed -e '/SECMOD_GetSystemFIPSEnabled/s/();/(void);/' -i /usr/include/nss3/pk11pub.h