Bug 1843604

Summary: reduce the cost of allocation/free when open/close a connection
Product: Red Hat Enterprise Linux 8 Reporter: mreynolds
Component: 389-ds-baseAssignee: thierry bordaz <tbordaz>
Status: CLOSED ERRATA QA Contact: RHDS QE <ds-qe-bugs>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 8.1CC: bsmejkal, nsoman, pasik, sgouvern, spichugi, tbordaz, vashirov
Target Milestone: rcKeywords: Triaged
Target Release: 8.0Flags: pm-rhel: mirror+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: sync-to-jira
Fixed In Version: 389-ds-1.4-8040020201125182123.866effaa Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-05-18 15:45:16 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description mreynolds 2020-06-03 16:11:06 UTC
Issue Description

Using searchrate/mutrace there is a contention on pthread_mutex_init. fixing this contention give a throughput gain (~15%)
Package Version and Platform

1.4.3
Steps to reproduce

Import 100K entries + searchrate
Actual results

    /lib64/libmutrace.so(pthread_mutex_init+0xf4) [0x7fef8b5082d4]
    /sbin/ns-slapd(connection_table_get_connection+0x1b3) [0x41c5c5]
    /sbin/ns-slapd() [0x421563]
    /sbin/ns-slapd() [0x41ea0e]
    /sbin/ns-slapd(slapd_daemon+0x743) [0x41f87e]
    /sbin/ns-slapd(main+0xead) [0x428786]
    /lib64/libc.so.6(__libc_start_main+0xf3) [0x7fef8acdf1a3]
    /sbin/ns-slapd(_start+0x2e) [0x411a4e]

Expected results

No contention at this point



Upstream ticket:

https://pagure.io/389-ds-base/issue/51131

Comment 1 thierry bordaz 2020-06-17 14:00:44 UTC
Fixed upstream with a patch provided by William. -> POST

Comment 11 sgouvern 2020-11-23 10:22:24 UTC
Need more time to ensure sanity checking, moving to ITM 4

Comment 13 sgouvern 2020-11-23 14:52:39 UTC
Being on branch : origin/stream-1.4-rhel-8.4.0 / rhpkg prep / 389-ds-base-1.4.3.16 directory :

changes in ldap/servers/slapd/conntable.c are not present, it seems that they have not been backported.
marking ASSIGNED and FailedQA

Comment 16 sgouvern 2020-11-30 08:50:56 UTC
On branch : origin/stream-1.4-rhel-8.4.0 / rhpkg prep / 389-ds-base-1.4.3.16 directory, for build 389-ds-base-1.4.3.16-3.module+el8.4.0+8869+55706461.x86_64

Changes are present in ldap/servers/slapd/conntable.c

Marking as verified:tested

Comment 19 sgouvern 2020-11-30 16:42:27 UTC
verified:tested (see comment 16) with build 389-ds-1.4-8040020201125182123.866effaa 
-> marking as VERIFIED

Comment 21 errata-xmlrpc 2021-05-18 15:45:16 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (389-ds:1.4 bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:1835