Bug 1844184 (CVE-2020-11089)

Summary:	CVE-2020-11089 freerdp: out-of-bounds read in irp functions
Product:	[Other] Security Response	Reporter:	Guilherme de Almeida Suckevicz <gsuckevi>
Component:	vulnerability	Assignee:	Red Hat Product Security <security-response-team>
Status:	CLOSED ERRATA	QA Contact:
Severity:	low	Docs Contact:
Priority:	low
Version:	unspecified	CC:	mads, negativo17, oholy, pahan
Target Milestone:	---	Keywords:	Security
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	freerdp 2.1.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-09-29 22:01:42 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1844185, 1844186, 1844187, 1844188, 1844616, 1844617
Bug Blocks:	1844196

Description Guilherme de Almeida Suckevicz 2020-06-04 18:25:30 UTC

In FreeRDP before 2.1.0, there is an out-of-bound read in irp functions (parallel_process_irp_create, serial_process_irp_create, drive_process_irp_write, printer_process_irp_write, rdpei_recv_pdu, serial_process_irp_write). This has been fixed in 2.1.0.

Reference:
https://github.com/FreeRDP/FreeRDP/security/advisories/GHSA-hfc7-c5gv-8c2h

Upstream commits:
https://github.com/FreeRDP/FreeRDP/commit/6b485b146a1b9d6ce72dfd7b5f36456c166e7a16
https://github.com/FreeRDP/FreeRDP/commit/795842f4096501fcefc1a7f535ccc8132feb31d7

Comment 1 Guilherme de Almeida Suckevicz 2020-06-04 18:25:58 UTC

Created freerdp tracking bugs for this issue:

Affects: epel-6 [bug 1844187]
Affects: fedora-all [bug 1844186]


Created freerdp1.2 tracking bugs for this issue:

Affects: epel-7 [bug 1844188]
Affects: fedora-all [bug 1844185]

Comment 2 Todd Cullum 2020-06-05 18:52:31 UTC

Mitigation:

The vulnerability is associated with the use of the command line options: /drive, +multitouch, /paralell, /printer, and /servial. To mitigate this vulnerability, do not use these commands.

Comment 3 Todd Cullum 2020-06-05 19:02:11 UTC

Technical Summary:

The affected components do not check to ensure that data is not read past the end of the stream buffer. The patch uses Stream_SafeSeek() and Stream_GetRemainingLength() to prevent this, before reading from the stream. This vulnerability affects the freerdp client application.

Comment 5 errata-xmlrpc 2020-09-29 20:44:10 UTC

This issue has been addressed in the following products:

  Red Hat Enterprise Linux 7

Via RHSA-2020:4031 https://access.redhat.com/errata/RHSA-2020:4031

Comment 6 Product Security DevOps Team 2020-09-29 22:01:42 UTC

This bug is now closed. Further updates for individual products will be reflected on the CVE page(s):

https://access.redhat.com/security/cve/cve-2020-11089

Comment 7 errata-xmlrpc 2020-11-04 02:39:09 UTC

This issue has been addressed in the following products:

  Red Hat Enterprise Linux 8

Via RHSA-2020:4647 https://access.redhat.com/errata/RHSA-2020:4647