Bug 1844344

Summary: Why "satellite-capsule" package exists under satellite repository
Product: Red Hat Satellite Reporter: Kavita <kgaikwad>
Component: PackagingAssignee: satellite6-bugs <satellite6-bugs>
Status: CLOSED ERRATA QA Contact: Lukas Pramuk <lpramuk>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 6.8.0CC: egolov, ehelms, kgaikwad, mmccune, supatil, zhunting
Target Milestone: 6.9.0Keywords: Triaged
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-04-21 13:14:56 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Kavita 2020-06-05 07:24:41 UTC
Description of problem:

Foreman Maintain relies on the satellite-capsule package to identify capsule environments. 
With the new capsule upgrade scenario in foreman-maintain, it fails to decide which upgrade scenario to run when both satellite and satellite-capsule packages are installed on the server.

Failure -
Satellite upgrade job failed due to "Too many scenarios match {:tags=>[:upgrade_scenario, :pre_upgrade_checks]}" error

I would like to know insights why this package exists on Satellite? Can we remove this package to avoid conflicts?

Version-Release number of selected component (if applicable):
6.8

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:
satellite-capsule package exists on satellite

Expected results:
satellite-capsule package should not exist on satellite. 

Additional info:

Foreman Maintain side BZ - https://bugzilla.redhat.com/show_bug.cgi?id=1838382

Comment 1 Evgeni Golov 2020-07-08 12:28:16 UTC
So I don't see a *good* reason why this package should be shipped in the *Satellite* repositories. All it contains are dependencies that are needed on a pure Capsule. This has been the case since at least Satellite 6.2 -- I couldn't find older sources.

Adding NEEDINFO on Mike, he *might* have some historical knowledge ;-)

Either way, I think the fix you applied in BZ#1844344 is correct and should make foreman-maintain work correctly.

Now, we certainly can remove that package from the Satellite repositories (build team: needs comps change and an Obsoletes in the main satellite package, so that it gets removed from customer systems if it's installed now), but I don't think this BZ should block beta as there is nothing broken by it anymore? :)

Comment 2 Kavita 2020-07-13 08:51:34 UTC
(In reply to Evgeni Golov from comment #1)

> Either way, I think the fix you applied in BZ#1844344 is correct and should
> make foreman-maintain work correctly.
> 

Yes, with the fix for BZ#1844344 foreman-maintain is detecting upgrade scenario properly based on satellite or capsule server instead of giving a failure mentioned in the description. 

This is no longer blocker for foreman-maintain. But if this package is not required on satellite server then probably it should be removed.

Thanks!
Kavita

Comment 3 Kavita 2020-07-13 08:54:55 UTC
Sorry(In reply to Kavita from comment #2)
> (In reply to Evgeni Golov from comment #1)
> 
> > Either way, I think the fix you applied in BZ#1844344 is correct and should
> > make foreman-maintain work correctly.
> > 
> 
> Yes, with the fix for *BZ#1838382* foreman-maintain is detecting upgrade
> scenario properly based on satellite or capsule server instead of giving a
> failure mentioned in the description. 
> 
> This is no longer blocker for foreman-maintain. But if this package is not
> required on satellite server then probably it should be removed.
> 
> Thanks!
> Kavita

Comment 6 Lukas Pramuk 2021-03-10 09:53:20 UTC
VERIFIED.

@Satellite 6.9.0 Snap16

by the following steps:

# rpm -q satellite{,-capsule}
satellite-6.9.0-1.el7sat.noarch
package satellite-capsule is not installed

# yum --disableplugin=foreman-protector list satellite-capsule --showd
Loaded plugins: product-id, search-disabled-repos, subscription-manager
Error: No matching Packages to list

>>> satellite-capsule rpm is no longer present in Satellite repo

Comment 9 errata-xmlrpc 2021-04-21 13:14:56 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: Satellite 6.9 Release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:1313