Bug 1844481

Summary:	1.19 rebase: openshift-apiserver API conversions break – route group
Product:	OpenShift Container Platform	Reporter:	Stefan Schimanski <sttts>
Component:	Networking	Assignee:	Andrew McDermott <amcdermo>
Networking sub component:	router	QA Contact:	Hongan Li <hongli>
Status:	CLOSED NOTABUG	Docs Contact:
Severity:	urgent
Priority:	urgent	CC:	aos-bugs, bbennett, mfojtik, mmasters, sgreene, xxia
Version:	4.6
Target Milestone:	---
Target Release:	4.6.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	no-qe
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1844471	Environment:
Last Closed:	2020-08-27 17:39:04 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1844471

Description Stefan Schimanski 2020-06-05 13:58:15 UTC

+++ This bug was initially created as a clone of Bug #1844471 +++

Description of problem:

https://github.com/openshift/openshift-apiserver/pull/95 describes a blocker for the 1.19 rebase of openshift-apiserver: upstream k8s.io/apiserver has removed reflection based conversions for performance and correctness reasons (the reflection based conversion was never completely correct). Openshift-apiserver makes use of the old behaviour and we have to fix all API groups.

This dependent bug is about the following devex API groups:

route.openshift.io

Comment 1 Andrew McDermott 2020-06-17 11:10:21 UTC

I’m adding UpcomingSprint, because I was occupied by fixing bugs with
higher priority/severity, developing new features with higher
priority, or developing new features to improve stability at a macro
level. I will revisit this bug next sprint.

Comment 2 Miciah Dashiel Butler Masters 2020-06-19 17:17:02 UTC

Stefan, can you clarify what we need to fix?  As far as I can tell, none of the errors listed in https://github.com/openshift/openshift-apiserver/pull/95 are related to the route API, and we don't have any conversion functions in https://github.com/openshift/openshift-apiserver/blob/master/pkg/route/apis/route/v1/conversion.go.  I tried checking out https://github.com/openshift/openshift-apiserver/pull/95 and running `go test -mod=vendor ./pkg/route/...` and did not get any errors.  Can you provide the steps to reproduce the problem that we are expected to fix?

Comment 3 Andrew McDermott 2020-07-09 12:10:07 UTC

I’m adding UpcomingSprint, because I was occupied by fixing bugs with
higher priority/severity, developing new features with higher
priority, or developing new features to improve stability at a macro
level. I will revisit this bug next sprint.

Comment 4 Andrew McDermott 2020-07-30 10:05:09 UTC

I’m adding UpcomingSprint, because I was occupied by fixing bugs with
higher priority/severity, developing new features with higher
priority, or developing new features to improve stability at a macro
level. I will revisit this bug next sprint.

Comment 5 mfisher 2020-08-18 20:01:45 UTC

Target reset from 4.6 to 4.7 while investigation is either ongoing or not yet started.  Will be considered for earlier release versions when diagnosed and resolved.

Comment 6 Stefan Schimanski 2020-08-25 08:09:03 UTC

We need this for openshift-apiserver. We cannot move it to 4.7. Increasing priority. This is known since early June.