Bug 184450
| Summary: | Review Request: wcstools | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Sergio Pascual <sergio.pasra> |
| Component: | Package Review | Assignee: | Dan Horák <dan> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | Flags: | kevin:
fedora-cvs+
|
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-06-26 17:53:26 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Sergio Pascual
2006-03-08 21:37:15 UTC
All comment are lost, so I am moving this bug to the previous state. Great :( The current version of the packages is here: http://t-rex.fis.ucm.es/~spr/wcstools.spec http://t-rex.fis.ucm.es/~spr/wcstools-3.6.3-3.fc5.src.rpm I have fixed the most important problems with the code and asked upstream about the license. They say that the binaries should be GPL and the lib LGPL. They are also working on the warnings that appeared during the compilation the URL is http://t-rex.fis.ucm.es/~spr/wcstools-3.6.4-3.fc5.src.rpm :-) And I think that everything is cleared and so I will prepare formal review. A new upstream version wcstools has been released. It now includes de license files. These are the new SRPM and SPEC: http://t-rex.fis.ucm.es/~spr/wcstools.spec http://t-rex.fis.ucm.es/~spr/wcstools-3.6.5-1.src.rpm Review: - no defective rpmlint output - package name OK - spec file name OK, is in English and is legible - package meets the Packaging Guidelines - licenses OK (GPL/LGPL) and are included - source matches upstream - compiles and builds at least on i386 - no BuildRequires needed - no localized files - has a shared lib and uses ldconfig as scriptlet shell - creates and owns a directory and does not conflict with existing dirs - no duplicates files, permissions are set properly, uses %defattr - has %clean section - consistent use of macros - contains code - no large docs, %doc is not required during runtime - has devel subpackage, no pkgconfig file - no .la libtool archives - not a GUI application APPROVED Package Change Request ====================== Package Name: wcstools New Branches: EL-5 cvs done. |